Merge pull request #119 from questdb/feat/min-time-interval

add a field to plugin config editor to set default min time interval

Author: javier

pkg/plugin/settings.go

@@ -172,5 +172,11 @@ func LoadSettings(config backend.DataSourceInstanceSettings) (settings Settings,
 		}
 	}
 
+	if jsonData["timeInterval"] != nil {
+		if timeInterval, ok := jsonData["timeInterval"].(string); ok {
+			settings.TimeInterval = timeInterval
+		}
+	}
+
 	return settings, settings.isValid()
 }

src/data/QuestDbDatasource.ts

@@ -24,11 +24,13 @@ export class Datasource extends DataSourceWithBackend<QuestDBQuery, QuestDBConfi
   settings: DataSourceInstanceSettings<QuestDBConfig>;
   adHocFilter: AdHocFilter;
   skipAdHocFilter = false; // don't apply adhoc filters to the query
+  interval?: string;
 
   constructor(instanceSettings: DataSourceInstanceSettings<QuestDBConfig>) {
     super(instanceSettings);
     this.settings = instanceSettings;
     this.adHocFilter = new AdHocFilter();
+    this.interval = instanceSettings.jsonData?.timeInterval;
   }
 
   async metricFindQuery(query: QuestDBQuery | string, options: any) {

src/selectors.ts

@@ -94,6 +94,11 @@ export const Components = {
       tooltip:
         'The maximum amount of time (in seconds) a connection may be reused. If set to 0, connections are reused forever.',
     },
+    MinInterval: {
+      label: 'Min time interval',
+      tooltip:
+        'A lower limit for the auto-calculated interval used by $__sampleByInterval macro. Recommended to be set to write frequency, for example 1s if your data is written every second. Valid time identifiers are: ms, s, m, h, d',
+    },
   },
   QueryEditor: {
     CodeEditor: {

src/types.ts

@@ -29,6 +29,7 @@ export interface QuestDBConfig extends DataSourceJsonData {
   maxOpenConnections?: number;
   maxIdleConnections?: number;
   maxConnectionLifetime?: number;
+  timeInterval?: string;
 
   tlsMode?: PostgresTLSModes;
   tlsConfigurationMethod?: PostgresTLSMethods;

src/views/QuestDBConfigEditor.tsx

@@ -262,6 +262,19 @@ export const ConfigEditor: React.FC<Props> = (props) => {
             type="number"
           />
         </Field>
+        <Field
+          label={Components.ConfigEditor.MinInterval.label}
+          description={Components.ConfigEditor.MinInterval.tooltip}
+        >
+          <Input
+            name="timeInterval"
+            width={40}
+            value={jsonData.timeInterval || ''}
+            onChange={onUpdateDatasourceJsonDataOption(props, 'timeInterval')}
+            label={Components.ConfigEditor.MinInterval.label}
+            aria-label={Components.ConfigEditor.MinInterval.label}
+          />
+        </Field>
       </ConfigSection>
 
       <Divider />