-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add cifuzz CI config for OSS-Fuzz #7625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7625 +/- ##
=======================================
Coverage 99.57% 99.57%
=======================================
Files 1102 1102
Lines 98425 98425
=======================================
Hits 98005 98005
Misses 420 420 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pavoljuhas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for setting this up.
|
Hi @pavoljuhas! From my local test, the project name needs to be in lowercase, since it's used as a Docker image name, which has a lowercase restriction. I also updated my OSS-Fuzz commit accordingly, sorry about the confusion! Note: this command is from OSS-Fuzz debugging doc |
Change project name back to lowercase as it needs to work as (lowercase-only) Docker image name. Refs: - quantumlib#7625 (comment) - ToastCheng/oss-fuzz@7deb0b7 This reverts commit 31f8647.
Thank you for pointing this out! I have reverted back to the lowercase name. On a side note, I have reassigned the review to @mhucka who has more domain knowledge with CI workflows. |
mhucka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ToastCheng Thank you very much for your work! I'm sorry for the number of comments in my review. I tried to provide detailed explanations for why the changes are requested; I also realize that you used the suggested workflow from the cifuzz docs so the shortcomings in the workflow are actually theirs and not yours. Still, this seemed to be a opportunity to provide some information that may help future workflow-writing efforts. I hope you don't mind.
09af7fd to
bdba2c0
Compare
bdba2c0 to
39822da
Compare
|
@mhucka Thank you for the suggestions and detailed explanation! I have updated the PR accordingly. One thing I found tricky is that OSS-Fuzz doesn't have release/tag, so after the OSS-Fuzz side PR merged (so that oss-fuzz can recognize Cirq project), the commit sha needs to be updated. Related issues on this topic: |
Oh, I didn't know – thanks for that info. Hmmm this is a tricky case. I'm tempted to say it's better to use |
|
@ToastCheng Also, is the current failure in the CIFuzz job due to the hash issue? Would using If yes, I propose this approach:
|
After adding the Cirq to OSS-Fuzz project list, we'll need to configure GitHub action to run the CI fuzzer. This PR basically follows https://google.github.io/oss-fuzz/getting-started/continuous-integration/ to enable the workflow.
Partially implements #7515