Skip to content

Commit 09a8b99

Browse files
authored
Merge pull request #405 from qonversion/tech/sc-40232/sourceAndVersion
2 parents e702469 + 8eaf328 commit 09a8b99

File tree

13 files changed

+51
-35
lines changed

13 files changed

+51
-35
lines changed

android/src/main/kotlin/com/qonversion/flutter/sdk/qonversion_flutter_sdk/NoCodesPlugin.kt

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,17 @@ class NoCodesPlugin(private val messenger: BinaryMessenger, private val context:
6060
this.screenFailedToLoadEventStreamHandler = screenFailedToLoadListener.eventStreamHandler
6161
}
6262

63-
fun initializeNoCodes(projectKey: String, result: Result) {
63+
fun initializeNoCodes(args: Map<String, Any>, result: Result) {
64+
val projectKey = args["projectKey"] as? String ?: return result.noNecessaryDataError()
65+
val version = args["version"] as? String ?: return result.noNecessaryDataError()
66+
val source = args["source"] as? String ?: return result.noNecessaryDataError()
67+
6468
if (projectKey.isNotEmpty()) {
6569
// Initialize NoCodes Sandwich
6670
noCodesSandwich = NoCodesSandwich()
71+
72+
noCodesSandwich?.storeSdkInfo(context, source, version)
73+
6774
noCodesSandwich?.initialize(context, projectKey)
6875
noCodesSandwich?.setDelegate(this)
6976
result.success(null)

android/src/main/kotlin/com/qonversion/flutter/sdk/qonversion_flutter_sdk/QonversionPlugin.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ class QonversionPlugin : MethodCallHandler, FlutterPlugin, ActivityAware {
133133
"storeSdkInfo" -> storeSdkInfo(args, result)
134134
"identify" -> identify(args["userId"] as? String, result)
135135
// NoCodes methods
136-
"initializeNoCodes" -> noCodesPlugin?.initializeNoCodes(args["projectKey"] as? String ?: "", result)
136+
"initializeNoCodes" -> noCodesPlugin?.initializeNoCodes(args, result)
137137
"setScreenPresentationConfig" -> noCodesPlugin?.setScreenPresentationConfig(args["config"] as? Map<String, Any>, args["contextKey"] as? String, result)
138138
"showNoCodesScreen" -> noCodesPlugin?.showNoCodesScreen(args["contextKey"] as? String, result)
139139
else -> result.notImplemented()

example/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,7 @@ ios/Podfile.lock
3636

3737
# Android related
3838
android/keystore/
39+
.cxx/
3940

4041
# Web related
4142
lib/generated_plugin_registrant.dart

lib/qonversion_flutter.dart

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,9 @@ export 'src/dto/entitlement_source.dart';
77
export 'src/dto/entitlements_cache_lifetime.dart';
88
export 'src/dto/environment.dart';
99
export 'src/dto/launch_mode.dart';
10+
export 'src/dto/nocodes_events.dart';
1011
export 'src/dto/offerings.dart';
12+
export 'src/dto/presentation_config.dart';
1113
export 'src/dto/product.dart';
1214
export 'src/dto/product_type.dart';
1315
export 'src/dto/promotional_offer.dart';
@@ -42,10 +44,9 @@ export 'src/dto/store_product/product_offer_details.dart';
4244
export 'src/dto/store_product/product_price.dart';
4345
export 'src/dto/store_product/product_pricing_phase.dart';
4446
export 'src/dto/store_product/product_store_details.dart';
47+
export 'src/nocodes.dart';
48+
export 'src/nocodes_config.dart';
49+
export 'src/nocodes_config_builder.dart';
4550
export 'src/qonversion.dart';
4651
export 'src/qonversion_config.dart';
4752
export 'src/qonversion_config_builder.dart';
48-
export 'src/nocodes/nocodes.dart';
49-
export 'src/nocodes/nocodes_config.dart';
50-
export 'src/nocodes/nocodes_events.dart';
51-
export 'src/nocodes/presentation_config.dart';
File renamed without changes.
File renamed without changes.

lib/src/internal/constants.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,8 @@ class Constants {
3333
static const kDiscountId = 'discountId';
3434
static const kPromoOffer = 'promoOffer';
3535
static const kConfig = 'config';
36+
static const kVersion = 'version';
37+
static const kSource = 'source';
3638

3739
// MethodChannel methods names
3840
static const mInitialize = 'initialize';
@@ -74,6 +76,7 @@ class Constants {
7476
static const mShowNoCodesScreen = 'showNoCodesScreen';
7577
static const mCloseNoCodes = 'closeNoCodes';
7678

77-
// Numeric constants
79+
// Other constants
7880
static const skuDetailsPriceRatio = 1000000;
81+
static const sdkSource = "flutter";
7982
}

lib/src/nocodes/nocodes_internal.dart renamed to lib/src/internal/nocodes_internal.dart

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,11 @@
11
import 'dart:async';
22
import 'dart:io';
33
import 'package:flutter/services.dart';
4-
import 'nocodes_events.dart';
5-
import 'nocodes_config.dart';
6-
import 'nocodes.dart';
7-
import 'presentation_config.dart';
4+
import 'package:qonversion_flutter/src/internal/qonversion_internal.dart';
5+
import '../dto/nocodes_events.dart';
6+
import '../dto/presentation_config.dart';
7+
import '../nocodes_config.dart';
8+
import '../nocodes.dart';
89
import 'dart:convert';
910
import '../internal/constants.dart';
1011

@@ -28,9 +29,11 @@ class NoCodesInternal implements NoCodes {
2829
if (Platform.isMacOS) {
2930
return;
3031
}
31-
32+
3233
final args = {
3334
Constants.kProjectKey: config.projectKey,
35+
Constants.kVersion: QonversionInternal.sdkVersion,
36+
Constants.kSource: Constants.sdkSource,
3437
};
3538
_channel.invokeMethod(Constants.mInitializeNoCodes, args);
3639
}
@@ -152,4 +155,4 @@ class NoCodesInternal implements NoCodes {
152155

153156
await _channel.invokeMethod(Constants.mCloseNoCodes);
154157
}
155-
}
158+
}

lib/src/internal/qonversion_internal.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ import 'package:qonversion_flutter/src/internal/utils/string.dart';
1111
import 'constants.dart';
1212

1313
class QonversionInternal implements Qonversion {
14-
static const String _sdkVersion = "10.0.2";
14+
static const String sdkVersion = "10.0.2";
1515

1616
final MethodChannel _channel = MethodChannel('qonversion_plugin');
1717

@@ -402,8 +402,8 @@ class QonversionInternal implements Qonversion {
402402
// Private methods
403403
Future<void> _storeSdkInfo() =>
404404
_channel.invokeMethod(Constants.mStoreSdkInfo, {
405-
"version": _sdkVersion,
406-
"source": "flutter",
405+
Constants.kVersion: sdkVersion,
406+
Constants.kSource: Constants.sdkSource,
407407
});
408408

409409
static QPurchaseException _convertPurchaseException(PlatformException error) {

lib/src/nocodes/nocodes.dart renamed to lib/src/nocodes.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
import 'dart:async';
2-
import 'nocodes_events.dart';
2+
import 'dto/nocodes_events.dart';
3+
import 'dto/presentation_config.dart';
34
import 'nocodes_config.dart';
4-
import 'nocodes_internal.dart';
5-
import 'presentation_config.dart';
5+
import 'internal/nocodes_internal.dart';
66

77
/// Main No-Codes API class
88
///

0 commit comments

Comments
 (0)