[CLEAN] Synthetic Benchmark PR #137908 - Various tracing fixes #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark PR elastic#137908
Type: Clean (correct implementation)
Original PR Title: Various tracing fixes
Original PR Description: This PR fixes various issues causing an excessive volume of APM events and incorrectly reported transaction & span durations as described in further detail:
Only continue tracing in TaskManager if a parent APM trace context exists. Trace headers might
be set by external transactions as well. If present, it caused APMTracer to report a transaction
for every span when in fact being sampled out.
Correctly report the duration of transactions if not recording by not discarding the root span
immediately. These transactions might still get reported, but without spans.
Discard transient trace start time in
newTraceContextwhen a parent APM trace contextalready exists. If propagated, all spans would start at the same time.
Relates to ES-13389
Original PR URL: elastic#137908