Arm backend: Fix incorrect qparams propagation #15698
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some passes after q-dq-folding, metadata was naively copied to all new nodes in decomposition. This can lead to problems if these nodes were to be computed ahead of time. This is solved by introducing a new optional argument to create_node, called inherit_qparams that defaults to false. This means that you explicitly need to set it to True in order to inherit qparams from the original node. For call_operator passes, the metadata dict is copied and modified in each pass. The patch also removes a few duplicate passes in ArmPassManager. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I408be28fbe54a8c53e8c9d312db967f5d0a7dc8c
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15698
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 6 Unrelated FailuresAs of commit 5c67b45 with merge base c8e9684 ( NEW FAILURE - The following job has failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
Collaborator
|
Testfail with rsub :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some passes after q-dq-folding, metadata was naively copied to all new nodes in decomposition. This can lead to problems if these nodes were to be computed ahead of time. This is solved by introducing a new optional argument to create_node, called inherit_qparams that defaults to false. This means that you explicitly need to set it to True in order to inherit qparams from the original node. For call_operator passes, the metadata dict is copied and modified in each pass. The patch also removes a few duplicate passes in ArmPassManager.
cc @freddan80 @per @zingo @digantdesai