Arm backend: Return false on non-VK_SUCCESS in process_vgf #15697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace incorrect `return result;` (VkResult) in a bool path to avoid false success. Change-Id: I842ffbed90f3f511695fc06820c167246f92e13a Signed-off-by: Yufeng Shi <yufeng.shi@arm.com> Co-authored-by: Alan Liang <alan.liang@arm.com>
YufengShi-dudu
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15697
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (6 Unrelated Failures)As of commit 878ad1c with merge base c8e9684 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
ArmRyan
approved these changes
Nov 10, 2025
Collaborator
ArmRyan
left a comment
ArmRyan
left a comment
There was a problem hiding this comment.
Approved in internal review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace incorrect
return result;(VkResult) in a bool path to avoid false success.Change-Id: I842ffbed90f3f511695fc06820c167246f92e13a
cc @freddan80 @per @zingo @oscarandersson8218 @digantdesai