-
Notifications
You must be signed in to change notification settings - Fork 718
Add checks for compute_slice #15647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks for compute_slice #15647
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15647
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (5 Unrelated Failures)As of commit 188a1b2 with merge base b005f10 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
Summary: Add safety checks to compute_slice, to ensure that we: 1. Do not read outside of the src tensor bounds 2. Do not write outside of the output tensor bounds Differential Revision: D86433966
d48711e to
76ed804
Compare
Summary: Add safety checks to compute_slice, to ensure that we: 1. Do not read outside of the src tensor bounds 2. Do not write outside of the output tensor bounds Differential Revision: D86433966
33318db to
05695b6
Compare
Summary: Add safety checks to compute_slice, to ensure that we: 1. Do not read outside of the src tensor bounds 2. Do not write outside of the output tensor bounds Also pass in KernelRuntimeContext to use ET_KERNEL_CHECK_MSG and make errors non-fatal. Differential Revision: D86433966
05695b6 to
0cdd555
Compare
Summary: Add safety checks to compute_slice, to ensure that we: 1. Do not read outside of the src tensor bounds 2. Do not write outside of the output tensor bounds Also pass in KernelRuntimeContext to use ET_KERNEL_CHECK_MSG and make errors non-fatal. Differential Revision: D86433966
Summary: Add safety checks to compute_slice, to ensure that we: 1. Do not read outside of the src tensor bounds 2. Do not write outside of the output tensor bounds Also pass in KernelRuntimeContext to use ET_KERNEL_CHECK_MSG and make errors non-fatal. Reviewed By: JacobSzwejbka Differential Revision: D86433966
0cdd555 to
d89628b
Compare
Summary: Add safety checks to compute_slice, to ensure that we: 1. Do not read outside of the src tensor bounds 2. Do not write outside of the output tensor bounds Also pass in KernelRuntimeContext to use ET_KERNEL_CHECK_MSG and make errors non-fatal. Reviewed By: JacobSzwejbka Differential Revision: D86433966
9a579ff to
188a1b2
Compare
Summary: Add safety checks to compute_slice, to ensure that we: 1. Do not read outside of the src tensor bounds 2. Do not write outside of the output tensor bounds Also pass in KernelRuntimeContext to use ET_KERNEL_CHECK_MSG and make errors non-fatal. Reviewed By: JacobSzwejbka Differential Revision: D86433966
d89628b to
9a579ff
Compare
|
@pytorchbot cherry-pick --onto release/1.0 -c critical |
Cherry picking #15647The cherry pick PR is at #15786 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Summary:
Add safety checks to compute_slice, to ensure that we:
Differential Revision: D86433966