Skip to content

Conversation

@lucylq
Copy link
Contributor

@lucylq lucylq commented Nov 6, 2025

Summary:
Add safety checks to compute_slice, to ensure that we:

  1. Do not read outside of the src tensor bounds
  2. Do not write outside of the output tensor bounds

Differential Revision: D86433966

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/15647

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (5 Unrelated Failures)

As of commit 188a1b2 with merge base b005f10 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 6, 2025
@meta-codesync
Copy link

meta-codesync bot commented Nov 6, 2025

@lucylq has exported this pull request. If you are a Meta employee, you can view the originating Diff in D86433966.

@github-actions
Copy link

github-actions bot commented Nov 6, 2025

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

lucylq added a commit to lucylq/executorch-1 that referenced this pull request Nov 6, 2025
Summary:

Add safety checks to compute_slice, to ensure that we:

1. Do not read outside of the src tensor bounds
2. Do not write outside of the output tensor bounds

Differential Revision: D86433966
lucylq added a commit to lucylq/executorch-1 that referenced this pull request Nov 6, 2025
Summary:

Add safety checks to compute_slice, to ensure that we:

1. Do not read outside of the src tensor bounds
2. Do not write outside of the output tensor bounds

Differential Revision: D86433966
@lucylq lucylq force-pushed the export-D86433966 branch 2 times, most recently from 33318db to 05695b6 Compare November 6, 2025 19:36
lucylq added a commit to lucylq/executorch-1 that referenced this pull request Nov 6, 2025
Summary:

Add safety checks to compute_slice, to ensure that we:

1. Do not read outside of the src tensor bounds
2. Do not write outside of the output tensor bounds

Also pass in KernelRuntimeContext to use ET_KERNEL_CHECK_MSG and make errors non-fatal.

Differential Revision: D86433966
lucylq added a commit to lucylq/executorch-1 that referenced this pull request Nov 6, 2025
Summary:

Add safety checks to compute_slice, to ensure that we:

1. Do not read outside of the src tensor bounds
2. Do not write outside of the output tensor bounds

Also pass in KernelRuntimeContext to use ET_KERNEL_CHECK_MSG and make errors non-fatal.

Differential Revision: D86433966
lucylq added a commit to lucylq/executorch-1 that referenced this pull request Nov 11, 2025
Summary:

Add safety checks to compute_slice, to ensure that we:

1. Do not read outside of the src tensor bounds
2. Do not write outside of the output tensor bounds

Also pass in KernelRuntimeContext to use ET_KERNEL_CHECK_MSG and make errors non-fatal.

Reviewed By: JacobSzwejbka

Differential Revision: D86433966
Summary:

Add safety checks to compute_slice, to ensure that we:

1. Do not read outside of the src tensor bounds
2. Do not write outside of the output tensor bounds

Also pass in KernelRuntimeContext to use ET_KERNEL_CHECK_MSG and make errors non-fatal.

Reviewed By: JacobSzwejbka

Differential Revision: D86433966
lucylq added a commit to lucylq/executorch-1 that referenced this pull request Nov 11, 2025
Summary:

Add safety checks to compute_slice, to ensure that we:

1. Do not read outside of the src tensor bounds
2. Do not write outside of the output tensor bounds

Also pass in KernelRuntimeContext to use ET_KERNEL_CHECK_MSG and make errors non-fatal.

Reviewed By: JacobSzwejbka

Differential Revision: D86433966
@meta-codesync meta-codesync bot merged commit 319789c into pytorch:main Nov 11, 2025
167 of 196 checks passed
@lucylq
Copy link
Contributor Author

lucylq commented Nov 12, 2025

@pytorchbot cherry-pick --onto release/1.0 -c critical

pytorchbot pushed a commit that referenced this pull request Nov 12, 2025
Differential Revision: D86433966

Pull Request resolved: #15647

(cherry picked from commit 319789c)
@pytorchbot
Copy link
Collaborator

Cherry picking #15647

The cherry pick PR is at #15786 and it is recommended to link a critical cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported meta-exported

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants