Fix type checking in Sprite.texture setter (#1409)

* Replace double texture type check with single __debug__ short circuiting check

* Raise TypeError instead of ValueError on wrong type

* Add a test for raising a TypeError when something other than a texture is passed to the setter

Author: pushfoo

arcade/sprite.py

@@ -902,10 +902,9 @@ def texture(self, texture: Texture):
         if texture == self._texture:
             return
 
-        if not isinstance(texture, Texture):
-            raise ValueError(f"The 'texture' parameter must be an instance of arcade.Texture."
-                             f"It is an instance of '{type(texture)}'.")
-        assert isinstance(texture, Texture)
+        if __debug__ and not isinstance(texture, Texture):
+            raise TypeError(f"The 'texture' parameter must be an instance of arcade.Texture,"
+                            f" but is an instance of '{type(texture)}'.")
 
         self.clear_spatial_hashes()
         self._point_list_cache = None

tests/unit2/test_sprite.py

@@ -1,3 +1,5 @@
+import pytest as pytest
+
 import arcade
 
 frame_counter = 0
@@ -120,6 +122,15 @@ def on_draw():
     window.test(2)
 
 
+@pytest.mark.parametrize('not_a_texture', [
+    1, "not_a_texture", (1, 2, 3)
+])
+def test_sprite_texture_setter_raises_type_error_when_given_non_texture(not_a_texture):
+    sprite = arcade.Sprite(":resources:images/items/coinGold.png", 1.0)
+    with pytest.raises(TypeError):
+        sprite.texture = not_a_texture
+
+
 def test_sprite_sizes(window: arcade.Window):
     SIZE = 50
     SPACING = SIZE * 2