-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Open
Labels
documentationquestiontopic-developerIssues relevant to mypy developersIssues relevant to mypy developers
Description
Documentation
In action.yml, the GitHub Action installs project dependencies with:
"$VENV_PYTHON" -m pip download --dest="$VENV"/deps .
"$VENV_PYTHON" -m pip install -U --find-links="$VENV"/deps "$VENV"/deps/*instead of a more direct approach such as:
"$VENV_PYTHON" -m pip install .
I looked through the current file and the original commit that introduced the action (e028045), but I could not find an explanation for why this two-step install flow was
chosen.
Could you document the intended reason for this design?
Questions I am trying to answer:
- Is there a functional advantage over pip install . for this action?
- Is the goal to stage artifacts locally before installation, improve debuggability, or work around some pip / GitHub Actions behavior?
- If there is no longer a strong reason, would simplifying this step be acceptable?
A short comment in action.yml or a note in the action documentation would help future readers understand the tradeoff.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
documentationquestiontopic-developerIssues relevant to mypy developersIssues relevant to mypy developers