gh-161390: Reject non-ctypes objects assigned to pointer contents

Author: rajorin

Lib/test/test_ctypes/test_pointers.py

@@ -98,6 +98,19 @@ def test_change_pointers(self):
         x.value = -99
         self.assertEqual(res.contents.value, -99)
 
+    def test_contents_rejects_spoofed_class(self):
+        # gh-161390: __class__ must not make a non-ctypes object look valid.
+        class Forge:
+            __slots__ = ("a", "b", "c", "d")
+            __class__ = c_int
+
+            def __init__(self):
+                self.a = c_int(7)
+                self.b = self.c = self.d = None
+
+        with self.assertRaises(TypeError):
+            pointer(c_int(1)).contents = Forge()
+
     def test_callbacks_with_pointers(self):
         # a function type receiving a pointer
         PROTOTYPE = CFUNCTYPE(c_int, POINTER(c_int))

Misc/NEWS.d/next/Library/2026-11-05-15-20-00.gh-issue-161390.p8Kq2m.rst

@@ -0,0 +1,4 @@
+Assigning to the :attr:`contents` attribute of a :mod:`ctypes` pointer now
+raises :exc:`TypeError` when the value is not a ctypes object. A value
+whose ``__class__`` claimed to be a ctypes type could previously crash
+the interpreter.

Modules/_ctypes/_ctypes.c

@@ -5785,16 +5785,12 @@ Pointer_set_contents_lock_held(PyObject *op, PyObject *value, void *closure)
     assert(stginfo); /* Cannot be NULL for pointer instances */
     assert(stginfo->proto);
     if (!CDataObject_Check(st, value)) {
-        int res = PyObject_IsInstance(value, stginfo->proto);
-        if (res == -1)
-            return -1;
-        if (!res) {
-            PyErr_Format(PyExc_TypeError,
-                         "expected %s instead of %s",
-                         ((PyTypeObject *)(stginfo->proto))->tp_name,
-                         Py_TYPE(value)->tp_name);
-            return -1;
-        }
+        /* PyObject_IsInstance() follows a spoofed __class__ (gh-161390). */
+        PyErr_Format(PyExc_TypeError,
+                     "expected %s instead of %s",
+                     ((PyTypeObject *)(stginfo->proto))->tp_name,
+                     Py_TYPE(value)->tp_name);
+        return -1;
     }
 
     dst = (CDataObject *)value;