Skip to content

Commit 5172ac9

Browse files
authored
macOS installer: Properly pluralise "architectures" (#160759)
1 parent 67683da commit 5172ac9

2 files changed

Lines changed: 5 additions & 2 deletions

File tree

‎Mac/BuildScript/build-installer.py‎

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1402,7 +1402,10 @@ def patchFile(inPath, outPath):
14021402
data = data.replace('$FULL_VERSION', getFullVersion())
14031403
data = data.replace('$VERSION', getVersion())
14041404
data = data.replace('$MACOSX_DEPLOYMENT_TARGET', ''.join((DEPTARGET, ' or later')))
1405-
data = data.replace('$ARCHITECTURES', ", ".join(universal_opts_map[UNIVERSALARCHS]))
1405+
archs = universal_opts_map[UNIVERSALARCHS]
1406+
data = data.replace('$ARCHITECTURES', ", ".join(archs))
1407+
data = data.replace('$ARCHITECTURE_NOUN',
1408+
"architecture" if len(archs) == 1 else "architectures")
14061409
data = data.replace('$INSTALL_SIZE', installSize())
14071410
data = data.replace('$THIRD_PARTY_LIBS', "\\\n".join(THIRD_PARTY_LIBS))
14081411

‎Mac/BuildScript/resources/ReadMe.rtf‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
\margl1440\margr1440\vieww15140\viewh15740\viewkind0
77
\pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\pardirnatural\partightenfactor0
88

9-
\f0\fs24 \cf0 This package will install Python $FULL_VERSION for macOS $MACOSX_DEPLOYMENT_TARGET for the following architecture(s): $ARCHITECTURES.\
9+
\f0\fs24 \cf0 This package will install Python $FULL_VERSION for macOS $MACOSX_DEPLOYMENT_TARGET for the following $ARCHITECTURE_NOUN: $ARCHITECTURES.\
1010
\
1111
\pard\tx720\tx1440\tx2160\tx2880\tx3600\tx4320\tx5040\tx5760\tx6480\tx7200\tx7920\tx8640\pardirnatural\partightenfactor0
1212

0 commit comments

Comments
 (0)