Skip to content

Commit 1f10fcb

Browse files
committed
gh-110548: address review feedback (enable pip, propagate pip failures)
1 parent e10c4ff commit 1f10fcb

1 file changed

Lines changed: 4 additions & 10 deletions

File tree

Doc/library/venv.rst

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -568,6 +568,8 @@ created::
568568
def __init__(self, *args, **kwargs):
569569
self.packages = kwargs.pop('packages', [])
570570
self.verbose = kwargs.pop('verbose', False)
571+
# pip is required to install the requested packages.
572+
kwargs.setdefault('with_pip', True)
571573
super().__init__(*args, **kwargs)
572574

573575
def post_setup(self, context):
@@ -592,16 +594,8 @@ created::
592594
if not self.verbose:
593595
args.append('-q')
594596
args.extend(self.packages)
595-
sys.stderr.write('Installing packages: %s ...\n'
596-
% ', '.join(self.packages))
597-
result = subprocess.run(args, capture_output=not self.verbose)
598-
if result.returncode != 0:
599-
sys.stderr.write('Package installation failed '
600-
'(exit code %d).\n' % result.returncode)
601-
if result.stderr:
602-
sys.stderr.write(result.stderr.decode('utf-8'))
603-
else:
604-
sys.stderr.write('done.\n')
597+
print('Installing packages', ', '.join(self.packages), file=sys.stderr)
598+
subprocess.run(args, check=True)
605599

606600

607601
def main(args=None):

0 commit comments

Comments
 (0)