gh-50720: Copy winerror to URLError on Windows (#161047)

Author: vasiliyk

Doc/library/urllib.error.rst

@@ -29,7 +29,8 @@ The following exceptions are raised by :mod:`!urllib.error` as appropriate:
 
    .. versionchanged:: 3.16
       The :attr:`~OSError.errno` and :attr:`~OSError.strerror` attributes are
-      now set from :attr:`reason` when it is an :exc:`OSError`.
+      now set from :attr:`reason` when it is an :exc:`OSError`. On Windows,
+      :attr:`~OSError.winerror` is set as well.
 
 
 .. exception:: HTTPError(url, code, msg, hdrs, fp)

Lib/test/test_urllib2.py

@@ -104,6 +104,16 @@ def request(self, *args, **kwargs):
         self.assertEqual(err.errno, -2)
         self.assertEqual(err.strerror, 'Name or service not known')
 
+    @unittest.skipUnless(sys.platform == "win32", "Windows-specific test")
+    def test_URLError_OSError_attributes_winerror(self):
+        # gh-50720: OSError(errno, strerror, filename, winerror):
+        # on Windows the constructor derives errno from winerror.
+        os_error = OSError(0, "The system cannot find the path specified", None, 3)
+
+        err = urllib.error.URLError(os_error)
+        self.assertEqual(err.winerror, 3)
+        self.assertEqual(err.strerror, os_error.strerror)
+
 
 class RequestHdrsTests(unittest.TestCase):
 

Lib/urllib/error.py

@@ -11,6 +11,7 @@
 response.
 """
 import io
+import sys
 import urllib.response
 
 __all__ = ['URLError', 'HTTPError', 'ContentTooShortError']
@@ -32,6 +33,8 @@ def __init__(self, reason, filename=None):
             # it would have set from the wrapped error (gh-50720).
             self.errno = reason.errno
             self.strerror = reason.strerror
+            if sys.platform == 'win32':
+                self.winerror = reason.winerror
 
     def __str__(self):
         return '<urlopen error %s>' % self.reason

Misc/NEWS.d/next/Library/2026-10-29-20-52-57.gh-issue-50720.Kd1VMR.rst

@@ -1,3 +1,4 @@
 :exc:`urllib.error.URLError` now sets the :attr:`~OSError.errno` and
 :attr:`~OSError.strerror` attributes from
-:attr:`~urllib.error.URLError.reason` when it is an :exc:`OSError`.
+:attr:`~urllib.error.URLError.reason` when it is an :exc:`OSError`.  On
+Windows, :attr:`~OSError.winerror` is set as well.