Skip to content

constructor should allow the chroot to be specified as an optional keyword only parameter #800

Description

@ThosRTanner

What would you like to be added

For the chroot parameter to the constructor to be an optional keyword only parameter, rather than packed into the host list, and for set_hosts to not have the ability to even try to set the chroot.

Why is this needed

There is a lot of complicated code to deal with this. And is you can't use set_hosts to actually set the chroot, it's mostly wasted anyway. Additionally, once you've set the chroot, if you try to call set_hosts you have to match the chroot you passed last time, which is toilsome.

I realise this'd be an incompatible change and plenty of warning/deprecation messages would be required.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions