Skip to content

Commit 759b2a2

Browse files
committed
Clarify which argument is high or low limit.
1 parent 4924986 commit 759b2a2

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

src/websockets/asyncio/connection.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -63,14 +63,14 @@ def __init__(
6363
self.ping_interval = ping_interval
6464
self.ping_timeout = ping_timeout
6565
self.close_timeout = close_timeout
66-
self.max_queue: tuple[int | None, int | None]
6766
if isinstance(max_queue, int) or max_queue is None:
68-
self.max_queue = (max_queue, None)
67+
self.max_queue_high, self.max_queue_low = max_queue, None
6968
else:
70-
self.max_queue = max_queue
69+
self.max_queue_high, self.max_queue_low = max_queue
7170
if isinstance(write_limit, int):
72-
write_limit = (write_limit, None)
73-
self.write_limit = write_limit
71+
self.write_limit_high, self.write_limit_low = write_limit, None
72+
else:
73+
self.write_limit_high, self.write_limit_low = write_limit
7474

7575
# Inject reference to this instance in the protocol's logger.
7676
self.protocol.logger = logging.LoggerAdapter(
@@ -1005,11 +1005,15 @@ def set_recv_exc(self, exc: BaseException | None) -> None:
10051005
def connection_made(self, transport: asyncio.BaseTransport) -> None:
10061006
transport = cast(asyncio.Transport, transport)
10071007
self.recv_messages = Assembler(
1008-
*self.max_queue,
1008+
self.max_queue_high,
1009+
self.max_queue_low,
10091010
pause=transport.pause_reading,
10101011
resume=transport.resume_reading,
10111012
)
1012-
transport.set_write_buffer_limits(*self.write_limit)
1013+
transport.set_write_buffer_limits(
1014+
self.write_limit_high,
1015+
self.write_limit_low,
1016+
)
10131017
self.transport = transport
10141018

10151019
def connection_lost(self, exc: Exception | None) -> None:

src/websockets/sync/connection.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,11 +59,10 @@ def __init__(
5959
self.ping_interval = ping_interval
6060
self.ping_timeout = ping_timeout
6161
self.close_timeout = close_timeout
62-
self.max_queue: tuple[int | None, int | None]
6362
if isinstance(max_queue, int) or max_queue is None:
64-
self.max_queue = (max_queue, None)
63+
max_queue_high, max_queue_low = max_queue, None
6564
else:
66-
self.max_queue = max_queue
65+
max_queue_high, max_queue_low = max_queue
6766

6867
# Inject reference to this instance in the protocol's logger.
6968
self.protocol.logger = logging.LoggerAdapter(
@@ -92,7 +91,8 @@ def __init__(
9291

9392
# Assembler turning frames into messages and serializing reads.
9493
self.recv_messages = Assembler(
95-
*self.max_queue,
94+
max_queue_high,
95+
max_queue_low,
9696
pause=self.recv_flow_control.acquire,
9797
resume=self.recv_flow_control.release,
9898
)

0 commit comments

Comments
 (0)