Allow non-dictionary header arguments in request method

Author: irvind

hyper/http11/connection.py

@@ -10,6 +10,8 @@
 import socket
 import base64
 
+from collections import Iterable
+
 from .response import HTTP11Response
 from ..tls import wrap_socket, H2C_PROTOCOL
 from ..common.bufsocket import BufferedSocket
@@ -148,7 +150,9 @@ def request(self, method, url, body=None, headers={}):
         url = to_bytestring(url)
 
         if not isinstance(headers, HTTPHeaderMap):
-            # FIXME: Handle things that aren't dictionaries here.
+            if isinstance(headers, Iterable):
+                headers = dict(headers)
+
             headers = HTTPHeaderMap(headers.items())
 
         if self._sock is None:

test/test_http11.py

@@ -124,6 +124,25 @@ def test_basic_request(self):
 
         assert received == expected
 
+    def test_iterable_headers(self):
+        c = HTTP11Connection('httpbin.org')
+        c._sock = sock = DummySocket()
+
+        c.request('GET', '/get', headers=(('User-Agent', 'hyper'),))
+        
+        expected = (
+            b"GET /get HTTP/1.1\r\n"
+            b"User-Agent: hyper\r\n"
+            b"connection: Upgrade, HTTP2-Settings\r\n"
+            b"upgrade: h2c\r\n"
+            b"HTTP2-Settings: AAQAAP//\r\n"
+            b"host: httpbin.org\r\n"
+            b"\r\n"
+        )
+        received = b''.join(sock.queue)
+
+        assert received == expected
+
     def test_proxy_request(self):
         c = HTTP11Connection('httpbin.org', proxy_host='localhost')
         c._sock = sock = DummySocket()