Remove dict.keys() when unnecessary

Author: Armavica

pytensor/compile/function/types.py

@@ -659,7 +659,7 @@ def checkSV(sv_ori, sv_rpl):
             exist_svs = [i.variable for i in maker.inputs]
 
             # Check if given ShareVariables exist
-            for sv in swap.keys():
+            for sv in swap:
                 if sv not in exist_svs:
                     raise ValueError(f"SharedVariable: {sv.name} not found")
 
@@ -711,9 +711,9 @@ def checkSV(sv_ori, sv_rpl):
         # it is well tested, we don't share the part of the storage_map.
         if share_memory:
             i_o_vars = maker.fgraph.inputs + maker.fgraph.outputs
-            for key in storage_map.keys():
+            for key, val in storage_map.items():
                 if key not in i_o_vars:
-                    new_storage_map[memo[key]] = storage_map[key]
+                    new_storage_map[memo[key]] = val
 
         if not name and self.name:
             name = self.name + " copy"
@@ -1446,7 +1446,7 @@ def prepare_fgraph(
         if not hasattr(mode.linker, "accept"):
             raise ValueError(
                 "'linker' parameter of FunctionMaker should be "
-                f"a Linker with an accept method or one of {list(pytensor.compile.mode.predefined_linkers.keys())}"
+                f"a Linker with an accept method or one of {list(pytensor.compile.mode.predefined_linkers)}"
             )
 
     def __init__(

pytensor/compile/profiling.py

@@ -1446,7 +1446,7 @@ def summary(self, file=sys.stderr, n_ops_to_print=20, n_apply_to_print=20):
                 file=file,
             )
         if config.profiling__debugprint:
-            fcts = {fgraph for (fgraph, n) in self.apply_time.keys()}
+            fcts = {fgraph for (fgraph, n) in self.apply_time}
             pytensor.printing.debugprint(fcts, print_type=True)
         if self.variable_shape or self.variable_strides:
             self.summary_memory(file, n_apply_to_print)

pytensor/configdefaults.py

@@ -1318,7 +1318,7 @@ def add_caching_dir_configvars():
     _compiledir_format_dict["short_platform"] = short_platform()
     # Allow to have easily one compiledir per device.
     _compiledir_format_dict["device"] = config.device
-    compiledir_format_keys = ", ".join(sorted(_compiledir_format_dict.keys()))
+    compiledir_format_keys = ", ".join(sorted(_compiledir_format_dict))
     _default_compiledir_format = (
         "compiledir_%(short_platform)s-%(processor)s-"
         "%(python_version)s-%(python_bitwidth)s"

pytensor/configparser.py

@@ -214,7 +214,7 @@ def change_flags(self, *args, **kwargs) -> _ChangeFlagsDecorator:
         return _ChangeFlagsDecorator(*args, _root=self, **kwargs)
 
     def warn_unused_flags(self):
-        for key in self._flags_dict.keys():
+        for key in self._flags_dict:
             warnings.warn(f"PyTensor does not recognise this flag: {key}")
 
 

pytensor/gradient.py

@@ -500,7 +500,7 @@ def grad(
     if cost is not None:
         outputs.append(cost)
     if known_grads is not None:
-        outputs.extend(list(known_grads.keys()))
+        outputs.extend(list(known_grads))
 
     var_to_app_to_idx = _populate_var_to_app_to_idx(outputs, _wrt, consider_constant)
 
@@ -966,7 +966,7 @@ def visit(var):
         visit(elem)
 
     # Remove variables that don't have wrt as a true ancestor
-    orig_vars = list(var_to_app_to_idx.keys())
+    orig_vars = list(var_to_app_to_idx)
     for var in orig_vars:
         if var not in visited:
             del var_to_app_to_idx[var]

pytensor/graph/basic.py

@@ -631,7 +631,7 @@ def convert_string_keys_to_variables(inputs_to_values) -> dict["Variable", Any]:
         if not hasattr(self, "_fn_cache"):
             self._fn_cache: dict = dict()
 
-        inputs = tuple(sorted(parsed_inputs_to_values.keys(), key=id))
+        inputs = tuple(sorted(parsed_inputs_to_values, key=id))
         cache_key = (inputs, tuple(kwargs.items()))
         try:
             fn = self._fn_cache[cache_key]

pytensor/graph/destroyhandler.py

@@ -406,7 +406,7 @@ def recursive_destroys_finder(protected_var):
                     # If True means that the apply node, destroys the protected_var.
                     if idx in [dmap for sublist in destroy_maps for dmap in sublist]:
                         return True
-                    for var_idx in app.op.view_map.keys():
+                    for var_idx in app.op.view_map:
                         if idx in app.op.view_map[var_idx]:
                             # We need to recursively check the destroy_map of all the
                             # outputs that we have a view_map on.

pytensor/graph/rewriting/basic.py

@@ -15,7 +15,7 @@
 from collections.abc import Iterable as IterableType
 from functools import _compose_mro, partial, reduce  # type: ignore
 from itertools import chain
-from typing import TYPE_CHECKING, Literal, cast
+from typing import TYPE_CHECKING, Literal
 
 import pytensor
 from pytensor.configdefaults import config
@@ -1924,9 +1924,9 @@ def process_node(
         remove: list[Variable] = []
         if isinstance(replacements, dict):
             if "remove" in replacements:
-                remove = list(cast(Sequence[Variable], replacements.pop("remove")))
-            old_vars = list(cast(Sequence[Variable], replacements.keys()))
-            replacements = list(cast(Sequence[Variable], replacements.values()))
+                remove = list(replacements.pop("remove"))
+            old_vars = list(replacements)
+            replacements = list(replacements.values())
         elif not isinstance(replacements, tuple | list):
             raise TypeError(
                 f"Node rewriter {node_rewriter} gave wrong type of replacement. "

pytensor/graph/utils.py

@@ -168,7 +168,7 @@ class MissingInputError(Exception):
     def __init__(self, *args, **kwargs):
         if kwargs:
             # The call to list is needed for Python 3
-            assert list(kwargs.keys()) == ["variable"]
+            assert list(kwargs) == ["variable"]
             error_msg = get_variable_trace_string(kwargs["variable"])
             if error_msg:
                 args = (*args, error_msg)

pytensor/link/c/params_type.py

@@ -264,10 +264,7 @@ def __init__(self, params_type, **kwargs):
     def __repr__(self):
         return "Params({})".format(
             ", ".join(
-                [
-                    (f"{k}:{type(self[k]).__name__}:{self[k]}")
-                    for k in sorted(self.keys())
-                ]
+                [(f"{k}:{type(self[k]).__name__}:{self[k]}") for k in sorted(self)]
             )
         )
 
@@ -365,7 +362,7 @@ def __init__(self, **kwargs):
                 )
 
         self.length = len(kwargs)
-        self.fields = tuple(sorted(kwargs.keys()))
+        self.fields = tuple(sorted(kwargs))
         self.types = tuple(kwargs[field] for field in self.fields)
         self.name = self.generate_struct_name()