Commit 3fee52c
committed
Do not use the disconnect method to tear down on pong timeout
The `disconnect` method is public, and tests the current state before
taking action, scheduling this work to happen on the event thread.
However, when a pong times out, the `onClose` is executed immediately,
transitioning in to the reconnecting state before the scheduled
disconnect happens, meaning disconnect fails to take any action and
potentially resulting in the old connection not being torn down.1 parent 979d537 commit 3fee52c
File tree
1 file changed
+1
-1
lines changed- src/main/java/com/pusher/client/connection/websocket
1 file changed
+1
-1
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
403 | 403 | | |
404 | 404 | | |
405 | 405 | | |
406 | | - | |
| 406 | + | |
407 | 407 | | |
408 | 408 | | |
409 | 409 | | |
| |||
0 commit comments