Skip to content

Commit dc88172

Browse files
authored
Merge pull request #159 from pusher/remove-old-pn-client
Drop NotificationClient
2 parents 97cfe22 + bab7840 commit dc88172

File tree

4 files changed

+3
-166
lines changed

4 files changed

+3
-166
lines changed

CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
1-
### next
1+
### next (major)
22

33
* [ADDED] option `encryption_master_key_base64`
44
* [DEPRECATED] option `encryption_master_key`
55

6+
* [REMOVED] old support for Push Notifications, see https://github.com/pusher/push-notifications-python
7+
68
### 2.1.4 2019-08-09
79

810
* [FIXED] TypeError in AuthenticationClient when using encrypted channels

pusher/notification_client.py

Lines changed: 0 additions & 81 deletions
This file was deleted.

pusher/pusher.py

Lines changed: 0 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
doc_string)
2020

2121
from pusher.pusher_client import PusherClient
22-
from pusher.notification_client import NotificationClient
2322
from pusher.authentication_client import AuthenticationClient
2423

2524

@@ -60,8 +59,6 @@ def __init__(
6059
json_encoder=None,
6160
json_decoder=None,
6261
backend=None,
63-
notification_host=None,
64-
notification_ssl=True,
6562
**backend_options):
6663

6764
self._pusher_client = PusherClient(
@@ -96,20 +93,6 @@ def __init__(
9693
backend,
9794
**backend_options)
9895

99-
self._notification_client = NotificationClient(
100-
app_id,
101-
key,
102-
secret,
103-
notification_ssl,
104-
notification_host,
105-
port,
106-
timeout,
107-
cluster,
108-
json_encoder,
109-
json_decoder,
110-
backend,
111-
**backend_options)
112-
11396

11497
@classmethod
11598
def from_url(cls, url, **options):
@@ -197,8 +180,3 @@ def authenticate(self, channel, socket_id, custom_data=None):
197180
def validate_webhook(self, key, signature, body):
198181
return self._authentication_client.validate_webhook(
199182
key, signature, body)
200-
201-
202-
@doc_string(NotificationClient.notify.__doc__)
203-
def notify(self, interest, notification):
204-
return self._notification_client.notify(interest, notification)

pusher_tests/test_notification_client.py

Lines changed: 0 additions & 62 deletions
This file was deleted.

0 commit comments

Comments
 (0)