🐛 Fix the sidebar creation

Author: trickypr

package.json

@@ -22,6 +22,7 @@
     "package": "gluon package",
     "ff-version": "gluon ff-version",
     "licenseCheck": "gluon license-check",
-    "gluon": "gluon"
+    "gluon": "gluon",
+    "reset": "gluon reset"
   }
 }

src/browser/base/content/browser-menubar-inc.patch

@@ -0,0 +1,14 @@
+diff --git a/browser/base/content/browser-menubar.inc b/browser/base/content/browser-menubar.inc
+index f3134d5a9a01b7965eede5695def5afef4a66d6b..626fba18a7e9341731f6b71a98197695d63d7c6c 100644
+--- a/browser/base/content/browser-menubar.inc
++++ b/browser/base/content/browser-menubar.inc
+@@ -153,6 +153,9 @@
+                               type="checkbox"
+                               class="sync-ui-item"
+                               oncommand="SidebarUI.toggle('viewTabsSidebar');" data-l10n-id="menu-view-synced-tabs-sidebar"/>
++                    <menuitem id="menu_downloadsSidebar"
++                              type="checkbox"
++                              oncommand="SidebarUI.toggle('viewDownloadsSidebar');" data-l10n-id="navbar-downloads"/>
+                   </menupopup>
+                 </menu>
+                 <menuseparator/>

src/browser/base/content/browser-sidebar-js.patch

@@ -1,5 +1,5 @@
 diff --git a/browser/base/content/browser-sidebar.js b/browser/base/content/browser-sidebar.js
-index f09e37fc42f7754f7f3687884ead25124c1b2076..5c75aaac3396ee8a837458942fc9bfc949f6d8df 100644
+index f09e37fc42f7754f7f3687884ead25124c1b2076..e1833bbfd8a8ed7da767349f886d554f3dd795f3 100644
 --- a/browser/base/content/browser-sidebar.js
 +++ b/browser/base/content/browser-sidebar.js
 @@ -11,6 +11,10 @@ var SidebarUI = {
@@ -37,22 +37,23 @@ index f09e37fc42f7754f7f3687884ead25124c1b2076..5c75aaac3396ee8a837458942fc9bfc9
          }),
        ],
        [
-@@ -47,8 +54,36 @@ var SidebarUI = {
+@@ -47,8 +54,37 @@ var SidebarUI = {
            elementId: "sidebar-switcher-tabs",
            url: "chrome://browser/content/syncedtabs/sidebar.xhtml",
            menuId: "menu_tabsSidebar",
 +          iconurl: "chrome://browser/skin/tab.svg",
-         }),
-       ],
++        }),
++      ],
 +      [
-+        "sidebar-downloads",
-+        {
++        "viewDownloadsSidebar",
++        makeSidebar({
++          elementId: "sidebar-switcher-downloads",
 +          title: "Downloads",
 +          url: "about:downloads",
-+          iconurl: "chrome://browser/skin/downloads/downloads.svg",
-+          isBottom: false,
-+        },
-+      ],
++          menuId: "menu_downloadsSidebar",
++          iconurl: "chrome://browser/skin/downloads/downloads.svg"
+         }),
+       ],
 +      [
 +        "sidebar-view-addons",
 +        {
@@ -74,7 +75,7 @@ index f09e37fc42f7754f7f3687884ead25124c1b2076..5c75aaac3396ee8a837458942fc9bfc9
      ]));
    },
 
-@@ -61,6 +96,8 @@ var SidebarUI = {
+@@ -61,6 +97,8 @@ var SidebarUI = {
      return (this._browser = document.getElementById("sidebar"));
    },
    POSITION_START_PREF: "sidebar.position_start",
@@ -83,7 +84,7 @@ index f09e37fc42f7754f7f3687884ead25124c1b2076..5c75aaac3396ee8a837458942fc9bfc9
    DEFAULT_SIDEBAR_ID: "viewBookmarksSidebar",
 
    // lastOpenedId is set in show() but unlike currentID it's not cleared out on hide
-@@ -78,6 +115,8 @@ var SidebarUI = {
+@@ -78,6 +116,8 @@ var SidebarUI = {
    },
    _splitter: null,
    _icon: null,
@@ -92,7 +93,7 @@ index f09e37fc42f7754f7f3687884ead25124c1b2076..5c75aaac3396ee8a837458942fc9bfc9
    _reversePositionButton: null,
    _switcherPanel: null,
    _switcherTarget: null,
-@@ -110,10 +149,40 @@ var SidebarUI = {
+@@ -110,10 +150,40 @@ var SidebarUI = {
      this._switcherTarget = document.getElementById("sidebar-switcher-target");
      this._switcherArrow = document.getElementById("sidebar-switcher-arrow");
 
@@ -133,7 +134,7 @@ index f09e37fc42f7754f7f3687884ead25124c1b2076..5c75aaac3396ee8a837458942fc9bfc9
      this._inited = true;
 
      Services.obs.addObserver(this, "intl:app-locales-changed");
-@@ -159,17 +228,26 @@ var SidebarUI = {
+@@ -159,17 +229,26 @@ var SidebarUI = {
    /**
     * The handler for Services.obs.addObserver.
     **/
@@ -164,7 +165,7 @@ index f09e37fc42f7754f7f3687884ead25124c1b2076..5c75aaac3396ee8a837458942fc9bfc9
        }
      }
    },
-@@ -573,6 +651,10 @@ var SidebarUI = {
+@@ -573,6 +652,10 @@ var SidebarUI = {
        this._box.setAttribute("sidebarcommand", commandID);
        this.lastOpenedId = commandID;
 
@@ -175,7 +176,7 @@ index f09e37fc42f7754f7f3687884ead25124c1b2076..5c75aaac3396ee8a837458942fc9bfc9
        let { url, title, sourceL10nEl } = this.sidebars.get(commandID);
        this.title = title;
        // Keep the title element in sync with any l10n changes.
-@@ -618,6 +700,26 @@ var SidebarUI = {
+@@ -618,6 +701,26 @@ var SidebarUI = {
 
      this.selectMenuItem("");
 
@@ -202,7 +203,7 @@ index f09e37fc42f7754f7f3687884ead25124c1b2076..5c75aaac3396ee8a837458942fc9bfc9
      // Replace the document currently displayed in the sidebar with about:blank
      // so that we can free memory by unloading the page. We need to explicitly
      // create a new content viewer because the old one doesn't get destroyed
-@@ -641,25 +743,112 @@ var SidebarUI = {
+@@ -641,25 +744,112 @@ var SidebarUI = {
     * none if the argument is an empty string.
     */
    selectMenuItem(commandID) {