freedv 2020B MPP ctest, and 2020B memory leak ctests

Author: drowe67

CMakeLists.txt

@@ -786,6 +786,14 @@ if(LPCNET)
                             ./ch - - --No -24 --mpp --fading_dir ../unittest |
                             ./freedv_rx 2020A - /dev/null --testframes"
              )
+
+     add_test(NAME test_freedv_api_2020B_mpp
+             COMMAND sh -c "cd ${CMAKE_CURRENT_BINARY_DIR}/src;
+                            dd bs=32000 count=60 if=/dev/zero |
+                            ./freedv_tx 2020B - - --testframes --clip 1 |
+                            ./ch - - --No -25 --mpp --fading_dir ../unittest |
+                            ./freedv_rx 2020B - /dev/null --testframes"
+             )
 endif()
 
      add_test(NAME test_freedv_api_2400A
@@ -967,16 +975,33 @@ if (NOT APPLE)
 if(LPCNET)
      add_test(NAME test_memory_leak_FreeDV_2020_tx
              COMMAND sh -c "cd  ${CMAKE_CURRENT_BINARY_DIR}/src;
-                            valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes ./freedv_tx 2020 ../../wav/wia_16kHz.wav /dev/null"
+                            valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes \
+                            ./freedv_tx 2020 ../../wav/wia_16kHz.wav /dev/null"
              )
              set_tests_properties(test_memory_leak_FreeDV_2020_tx PROPERTIES PASS_REGULAR_EXPRESSION "ERROR SUMMARY: 0 errors")
 
      add_test(NAME test_memory_leak_FreeDV_2020_rx
              COMMAND sh -c "cd  ${CMAKE_CURRENT_BINARY_DIR}/src;
                             ./freedv_tx 2020 ../../wav/wia_16kHz.wav t.raw; \
-                            valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes ./freedv_rx 2020 t.raw /dev/null"
+                            valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes \
+                            ./freedv_rx 2020 t.raw /dev/null"
              )
              set_tests_properties(test_memory_leak_FreeDV_2020_rx PROPERTIES PASS_REGULAR_EXPRESSION "ERROR SUMMARY: 0 errors")
+
+     add_test(NAME test_memory_leak_FreeDV_2020B_tx
+             COMMAND sh -c "cd  ${CMAKE_CURRENT_BINARY_DIR}/src;
+                            valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes \
+                            ./freedv_tx 2020B ../../wav/wia_16kHz.wav /dev/null"
+             )
+             set_tests_properties(test_memory_leak_FreeDV_2020B_tx PROPERTIES PASS_REGULAR_EXPRESSION "ERROR SUMMARY: 0 errors")
+
+     add_test(NAME test_memory_leak_FreeDV_2020B_rx
+             COMMAND sh -c "cd  ${CMAKE_CURRENT_BINARY_DIR}/src;
+                            ./freedv_tx 2020B ../../wav/wia_16kHz.wav t.raw; \
+                            valgrind --leak-check=full --show-leak-kinds=all --track-origins=yes \
+                            ./freedv_rx 2020B t.raw /dev/null"
+             )
+             set_tests_properties(test_memory_leak_FreeDV_2020B_rx PROPERTIES PASS_REGULAR_EXPRESSION "ERROR SUMMARY: 0 errors")
 endif(LPCNET)
 endif(NOT APPLE)
 

README_freedv.md

@@ -54,11 +54,13 @@ These are designed for use with a HF SSB radio.
 
 | Mode | Date | Codec | Modem | RF BW | Raw bits/s | FEC | Text bits/s | SNR min | Multipath |
 | --- | --- | --- | --- | --- | --- | --- | --- | --- | --- |
-| 1600 | 2012 | Codec2 1300 | 14 DQPSK + 1 DBPSK pilot carrier | 1125 | 1600 | Golay (23,12) | 25 | 4 | poor |
-| 700C | 2017 | Codec2 700C | 14 carrier coherent QPSK + diversity | 1500 | 1400 | - | - | 2 | good |
-| 700D | 2018 | Codec2 700C | 17 carrier coherent OFDM/QPSK | 1000 | 1900 | LDPC (224,112)  | 25 | -2 | fair |
-| 700E | 2020 | Codec2 700C | 21 carrier coherent OFDM/QPSK | 1500 | 3000 | LDPC (112,56)  | 25 | 1 | good |
-| 2020 | 2019 | LPCNet 1733 | 31 carrier coherent OFDM/QPSK | 1600 | 3000 | LDPC (504,396)  | 22.2 | 2 | poor |
+| 1600  | 2012 | Codec2 1300 | 14 DQPSK + 1 DBPSK pilot carrier | 1125 | 1600 | Golay (23,12) | 25 | 4 | poor |
+| 700C  | 2017 | Codec2 700C | 14 carrier coherent QPSK + diversity | 1500 | 1400 | - | - | 2 | good |
+| 700D  | 2018 | Codec2 700C | 17 carrier coherent OFDM/QPSK | 1000 | 1900 | LDPC (224,112)  | 25 | -2 | fair |
+| 700E  | 2020 | Codec2 700C | 21 carrier coherent OFDM/QPSK | 1500 | 3000 | LDPC (112,56)  | 25 | 1 | good |
+| 2020  | 2019 | LPCNet 1733 | 31 carrier coherent OFDM/QPSK | 1600 | 3000 | LDPC (504,396)  | 22.2 | 2 | poor |
+| 2020A | 2022 | LPCNet 1733 | 31 carrier coherent OFDM/QPSK | 1600 | 3000 | LDPC (504,396) unequal  | 22.2 | 2 | fair |
+| 2020B | 2022 | LPCNet 1733 | 29 carrier coherent OFDM/QPSK | 2100 | 4100 | LDPC (112,56) unequal  | 22.2 | 3 | good |
 
 Notes:
 
@@ -86,6 +88,8 @@ Notes:
 
 1. FEC was added fairly recently to FreeDV modes.  The voice codecs we use work OK at bit error rates of a few %, and packet error rates of 10%. Raw bit error rates on multipath channels often exceed 10%.  For reasonable latency (say 40ms) we need small codewords. Thus to be useful we require a FEC code that works at over 10% raw BER, has 1% output (coded) bit error rate, and a codeword of around 100 bits.  Digital voice has unusual requirements, most FEC codes are designed for data which is intolerant of any bit errors, and few operate over 10% raw BER.  Powerful FEC codes have long block lengths (1000's of bits) which leads to long latency.  However LDPC codes come close, and can also "clean up" other channel errors caused by static and interference.  The use of OFDM means we now have "room" for the extra bits required for FEC, so there is little cost in adding it, apart from latency.
 
+1. 2020A and 2020B use unequal error protection, only 11 bits from each 52 bit vocoder frame are protected by FEC.  This provides strong protection of the most important bits.  The effect is a gentle "slope" in the speech quality versus SNR curve.  These modes will work at lower SNRs that 2020, but will still have some audible errors even at high SNRs.  2020B has a modem waveform similar to 700E - a high pilot symbol rate so it operates on fast fading channels.  Compared to 2020 it has a shorter frame duration (90ms), lower latency and faster sync, but requires a few more dB SNR.
+
 ## FreeDV VHF Modes
 
 These modes use constant amplitude modulation like FSK or FM, and are designed for VHF and above.  However 800XA can be run over HF or VHF on a SSB radio.
@@ -196,6 +200,11 @@ $ ./src/freedv_tx 700D ../raw/ve9qrp.raw - --clip 0 --testframes | ./src/ch - -
 
 Adjust `--clip [0|1]` and `No` argument of `ch` to obtain a PER of just less than 0.1, and note the SNR and PAPR reported by `ch`.  The use of the `ve9qrp` samples makes the test run for a few minutes, in order to get reasonable multipath channel results.
 
+Low SNR MPP channel 2020B command line:
+```
+cat ~/LPCNet/wav/all.wav | ~/LPCNet/build_linux/src/lpcnet_enc -x | ./src/ofdm_mod --mode 2020B --ldpc --clip --txbpf | ./src/ch - - --No -22 --mpd | ./src/ofdm_demod --mode 2020B --verbose 1 --ldpc | ~/LPCNet/build_linux/src/lpcnet_dec -x | aplay -f S16_LE -r 16000
+```
+
 ## Reading Further
 
 1. [FreeDV web site](http://freedv.org)

src/freedv_2020.c

@@ -84,7 +84,7 @@ void freedv_2020x_open(struct freedv *f, int vq_type) {
     f->ofdm_nuwbits = f->ofdm->config.nuwbits;
     f->ofdm_ntxtbits = f->ofdm->config.txtbits;
     assert(f->ofdm_ntxtbits == 4);
-    f->verbose=1;
+    
     if (f->verbose) {
         fprintf(stderr, "f->mode = %d\n", f->mode);
         fprintf(stderr, "vq_type = %d\n", vq_type);

src/freedv_rx.c

@@ -308,8 +308,9 @@ int main(int argc, char *argv[]) {
         float uncoded_ber = (float)Terrs/Tbits;
         fprintf(stderr, "BER......: %5.4f  Tbits: %8d  Terrs: %8d\n",
 		                    (double)uncoded_ber, Tbits, Terrs);
-        if ((mode == FREEDV_MODE_700D) || (mode == FREEDV_MODE_700E) ||
-            (mode == FREEDV_MODE_2020) || (mode == FREEDV_MODE_2020A)) {
+        if ((mode == FREEDV_MODE_700D) || (mode == FREEDV_MODE_700E)  ||
+            (mode == FREEDV_MODE_2020) || (mode == FREEDV_MODE_2020A) ||
+            (mode == FREEDV_MODE_2020B) ) {
             int Tbits_coded = freedv_get_total_bits_coded(freedv);
             int Terrs_coded = freedv_get_total_bit_errors_coded(freedv);
             float coded_ber = (float)Terrs_coded/Tbits_coded;