Merge pull request #18 from protonemedia/select-bugfix-17

Fix for #17

Author: pascalbaljet

src/Components/FormSelect.php

@@ -2,6 +2,8 @@
 
 namespace ProtoneMedia\LaravelFormComponents\Components;
 
+use Illuminate\Support\Arr;
+
 class FormSelect extends Component
 {
     use HandlesValidationErrors;
@@ -47,14 +49,6 @@ public function isSelected($key): bool
             return false;
         }
 
-        if ($this->selectedKey === $key) {
-            return true;
-        }
-
-        if (is_array($this->selectedKey) && in_array($key, $this->selectedKey)) {
-            return true;
-        }
-
-        return false;
+        return in_array($key, Arr::wrap($this->selectedKey));
     }
 }

tests/Feature/SelectWithoutKeysTest.php

@@ -0,0 +1,41 @@
+<?php
+
+namespace ProtoneMedia\LaravelFormComponents\Tests\Feature;
+
+use Illuminate\Http\Request;
+use ProtoneMedia\LaravelFormComponents\Tests\TestCase;
+
+class SelectWithoutKeysTest extends TestCase
+{
+    /** @test */
+    public function it_makes_the_values_numeric()
+    {
+        $this->registerTestRoute('select-without-keys', function (Request $request) {
+            $request->validate([
+                'select' => 'required|in:a,b',
+            ]);
+        });
+
+        $this->visit('/select-without-keys')
+            ->seeInElement('option[value="0"]', 'a')
+            ->seeInElement('option[value="1"]', 'b')
+            ->seeInElement('option[value="2"]', 'c');
+    }
+
+    /** @test */
+    public function it_shows_a_validation_error()
+    {
+        $this->registerTestRoute('select-without-keys', function (Request $request) {
+            $request->validate([
+                'select' => 'required|in:0,1',
+            ]);
+        });
+
+        $this->visit('/select-without-keys')
+            ->select('2', 'select')
+            ->press('Submit')
+            ->seeElement('option[value="0"]:not(:selected)')
+            ->seeElement('option[value="1"]:not(:selected)')
+            ->seeElement('option[value="2"]:selected');
+    }
+}

tests/Feature/views/select-without-keys.blade.php

@@ -0,0 +1,4 @@
+<x-form>
+    <x-form-select name="select" :options="['a', 'b', 'c']" />
+    <x-form-submit />
+</x-form>