Fix that

Author: dcodeIO

ByteBuffer.js

@@ -2025,7 +2025,7 @@
          * @expose
          */
         ByteBuffer.prototype.toBase64 = function() {
-            if (this.array == null || this.offset < this.length) return "";
+            if (this.array == null || this.offset >= this.length) return "";
             return ByteBuffer.encode64(this);
         };
 
@@ -2035,7 +2035,7 @@
          * @expose
          */
         ByteBuffer.prototype.toUTF8 = function() {
-            if (this.array == null || this.offset < this.length) return "";
+            if (this.array == null || this.offset >= this.length) return "";
             return this.readUTF8StringBytes(this.length - this.offset, this.offset).string;
         };
 

ByteBuffer.min.js

@@ -1922,7 +1922,7 @@
          * @returns {string} Base 64 encoded string
          */
         ByteBuffer.prototype.toBase64 = function() {
-            if (this.array == null || this.offset < this.length) return "";
+            if (this.array == null || this.offset >= this.length) return "";
             return ByteBuffer.encode64(this);
         };
 
@@ -1931,7 +1931,7 @@
          * @returns {string}
          */
         ByteBuffer.prototype.toUTF8 = function() {
-            if (this.array == null || this.offset < this.length) return "";
+            if (this.array == null || this.offset >= this.length) return "";
             return this.readUTF8StringBytes(this.length - this.offset, this.offset).string;
         };
 

ByteBuffer.min.map

@@ -762,6 +762,22 @@ ByteBuffer.zigZagEncode32 = function(n) {};
  */
 ByteBuffer.zigZagDecode32 = function(n) {};
 
+/**
+ * @param {ByteBuffer} bb
+ * @return {string}
+ * @throws {Error}
+ * @nosideeffects
+ */
+ByteBuffer.encode64 = function(bb) {};
+
+/**
+ * @param {string} str
+ * @return {!ByteBuffer}
+ * @throws {Error}
+ * @nosideeffects
+ */
+ByteBuffer.decode64 = function(str) {};
+
 /**
  * @type {number}
  * @const

ByteBuffer.noexpose.js

@@ -2025,7 +2025,7 @@
          * @expose
          */
         ByteBuffer.prototype.toBase64 = function() {
-            if (this.array == null || this.offset < this.length) return "";
+            if (this.array == null || this.offset >= this.length) return "";
             return ByteBuffer.encode64(this);
         };
 
@@ -2035,7 +2035,7 @@
          * @expose
          */
         ByteBuffer.prototype.toUTF8 = function() {
-            if (this.array == null || this.offset < this.length) return "";
+            if (this.array == null || this.offset >= this.length) return "";
             return this.readUTF8StringBytes(this.length - this.offset, this.offset).string;
         };
 

externs/ByteBuffer.js

@@ -23,7 +23,7 @@
  * File to use.
  * @type {string}
  */
-var FILE = "ByteBuffer.js";
+var FILE = "ByteBuffer.min.js";
 
 /**
  * ByteBuffer.
@@ -769,6 +769,8 @@ var suite = {
             var bb = ByteBuffer.decode64(b64);
             test.strictEqual(bb.readUTF8String(str.length, 0).string, str);
             test.strictEqual(ByteBuffer.encode64(bb), b64);
+            test.strictEqual(bb.toBase64(), b64);
+            test.strictEqual(bb.toString("base64"), b64);
         }
         test.done();
     },