Skip to content

RHOAIENG-39075: Add new E2E test structure and initial existing cluster test #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 1, 2025
Merged

RHOAIENG-39075: Add new E2E test structure and initial existing cluster test #948

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/codeflare_sdk/ray/cluster/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,9 +98,9 @@ class ClusterConfiguration:

name: str
namespace: Optional[str] = None
head_cpu_requests: Union[int, str] = 2
head_cpu_requests: Union[int, str] = 1
head_cpu_limits: Union[int, str] = 2
head_memory_requests: Union[int, str] = 8
head_memory_requests: Union[int, str] = 5
head_memory_limits: Union[int, str] = 8
head_extended_resource_requests: Dict[str, Union[str, int]] = field(
default_factory=dict
Expand All @@ -109,8 +109,8 @@ class ClusterConfiguration:
worker_cpu_requests: Union[int, str] = 1
worker_cpu_limits: Union[int, str] = 1
num_workers: int = 1
worker_memory_requests: Union[int, str] = 2
worker_memory_limits: Union[int, str] = 2
worker_memory_requests: Union[int, str] = 3
worker_memory_limits: Union[int, str] = 6
worker_tolerations: Optional[List[V1Toleration]] = None
appwrapper: bool = False
envs: Dict[str, str] = field(default_factory=dict)
Expand Down
14 changes: 7 additions & 7 deletions src/codeflare_sdk/ray/cluster/test_pretty_print.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,15 +85,15 @@ def test_ray_details(mocker, capsys):
name="raytest1",
status=RayClusterStatus.READY,
num_workers=1,
worker_mem_requests="2G",
worker_mem_limits="2G",
worker_mem_requests="3G",
worker_mem_limits="6G",
worker_cpu_requests=1,
worker_cpu_limits=1,
namespace="ns",
dashboard="fake-uri",
head_cpu_requests=2,
head_cpu_requests=1,
head_cpu_limits=2,
head_mem_requests=8,
head_mem_requests=5,
head_mem_limits=8,
)
mocker.patch(
Expand Down Expand Up @@ -150,7 +150,7 @@ def test_ray_details(mocker, capsys):
" │ ╭── Workers ──╮ ╭───────── Worker specs(each) ─────────╮ │ \n"
" │ │ # Workers │ │ Memory CPU GPU │ │ \n"
" │ │ │ │ │ │ \n"
" │ │ 1 │ │ 2G~2G 1~1 0 │ │ \n"
" │ │ 1 │ │ 3G~6G 1~1 0 │ │ \n"
" │ │ │ │ │ │ \n"
" │ ╰─────────────╯ ╰──────────────────────────────────────╯ │ \n"
" ╰───────────────────────────────────────────────────────────────╯ \n"
Expand All @@ -168,7 +168,7 @@ def test_ray_details(mocker, capsys):
" │ ╭── Workers ──╮ ╭───────── Worker specs(each) ─────────╮ │ \n"
" │ │ # Workers │ │ Memory CPU GPU │ │ \n"
" │ │ │ │ │ │ \n"
" │ │ 1 │ │ 2G~2G 1~1 0 │ │ \n"
" │ │ 1 │ │ 3G~6G 1~1 0 │ │ \n"
" │ │ │ │ │ │ \n"
" │ ╰─────────────╯ ╰──────────────────────────────────────╯ │ \n"
" ╰───────────────────────────────────────────────────────────────╯ \n"
Expand All @@ -184,7 +184,7 @@ def test_ray_details(mocker, capsys):
"│ ╭── Workers ──╮ ╭───────── Worker specs(each) ─────────╮ │\n"
"│ │ # Workers │ │ Memory CPU GPU │ │\n"
"│ │ │ │ │ │\n"
"│ │ 1 │ │ 2G~2G 1~1 0 │ │\n"
"│ │ 1 │ │ 3G~6G 1~1 0 │ │\n"
"│ │ │ │ │ │\n"
"│ ╰─────────────╯ ╰──────────────────────────────────────╯ │\n"
"╰───────────────────────────────────────────────────────────────╯\n"
Expand Down
3 changes: 3 additions & 0 deletions src/codeflare_sdk/ray/rayjobs/rayjob.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,9 @@ def _validate_priority_class(self):
Raises ValueError if the priority class is definitively known not to exist.
If we cannot verify (e.g., permission denied), logs a warning and allows submission.
"""
if self._cluster_config is None:
return

if self.priority_class:
logger.debug(f"Validating priority class '{self.priority_class}'...")
exists = priority_class_exists(self.priority_class)
Expand Down
2 changes: 2 additions & 0 deletions tests/e2e_v2/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# E2E Test Suite v2
# Restructured pytest-based E2E tests for CodeFlare SDK
Empty file added tests/e2e_v2/cluster_management/__init__.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/configuration/__init__.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/configuration/test_advanced.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/configuration/test_heterogeneous.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/configuration/test_images.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/configuration/test_resources.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/configuration/test_volumes.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/creation/__init__.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/creation/test_cluster_creation.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/creation/test_cluster_kueue.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/interactive/__init__.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/interactive/test_in_cluster.py
View file
Open in desktop
Empty file.
Empty file added tests/e2e_v2/cluster_management/interactive/test_remote.py
View file
Open in desktop
Empty file.
Loading
Loading