-
Notifications
You must be signed in to change notification settings - Fork 59
build(deps): bump cryptography from 43.0.3 to 46.0.3 #931
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Bumps [cryptography](https://github.com/pyca/cryptography) from 43.0.3 to 46.0.3. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@43.0.3...46.0.3) --- updated-dependencies: - dependency-name: cryptography dependency-version: 46.0.3 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
7daaff6 to
0b0dcce
Compare
|
New changes are detected. LGTM label has been removed. |
…le certs for clusters to remove manual step
0b0dcce to
bac0fd2
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #931 +/- ##
==========================================
- Coverage 94.13% 91.34% -2.79%
==========================================
Files 24 24
Lines 2096 2206 +110
==========================================
+ Hits 1973 2015 +42
- Misses 123 191 +68 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| redis_address: Optional[str] = None | ||
| redis_password_secret: Optional[Dict[str, str]] = None | ||
| external_storage_namespace: Optional[str] = None | ||
| cleanup_tls_certs: bool = True |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be a new field or an env var? Only reason I'd veer towards an env var is the sheer number of params we already have in ClusterConfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree there's lots there. I think it's probably safe enough to attempt to delete the certs each time a cluster is deleted. They wont be needed after that anyway.
|
rebase Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Bumps cryptography from 43.0.3 to 46.0.3.
Changelog
Sourced from cryptography's changelog.
... (truncated)
Commits
c0af4ddrelease 46.0.3 (#13681)99efe5abump version for 46.0.2 (#13531)e735cfcrelease 46.0.1 (#13450)4e457ffExplicitly specify python in mac uv build invocation (#13447)2726efdDepend on CFFI 2.0.0 or newer on Python > 3.8 (#13448)6223062release 46.0.0 (#13446)563c491Update comment for pyopenssl-release tag (#13445)d2f6f7fBump downstream dependencies in CI (#13439)e7ab02bwe'll ship this with 3.5.3 why not (#13442)0b68a4bAnother pair of bump dependencies fix (#13444)You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Additional Changes added
Verification
cluster.wait_ready()verify that filesca.crt tls.crt tls.keyare create at/opt/app-root/src/.local/share/codeflare/tls/<clustername>-<namespace>