Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 16, 2025

Bumps cryptography from 43.0.3 to 46.0.3.

Changelog

Sourced from cryptography's changelog.

46.0.3 - 2025-10-15


* Fixed compilation when using LibreSSL 4.2.0.

.. _v46-0-2:

46.0.2 - 2025-09-30

  • Updated Windows, macOS, and Linux wheels to be compiled with OpenSSL 3.5.4.

.. _v46-0-1:

46.0.1 - 2025-09-16


* Fixed an issue where users installing via ``pip`` on Python 3.14 development
  versions would not properly install a dependency.
* Fixed an issue building the free-threaded macOS 3.14 wheels.

.. _v46-0-0:

46.0.0 - 2025-09-16

  • BACKWARDS INCOMPATIBLE: Support for Python 3.7 has been removed.
  • Support for OpenSSL < 3.0 is deprecated and will be removed in the next release.
  • Support for x86_64 macOS (including publishing wheels) is deprecated and will be removed in two releases. We will switch to publishing an arm64 only wheel for macOS.
  • Support for 32-bit Windows (including publishing wheels) is deprecated and will be removed in two releases. Users should move to a 64-bit Python installation.
  • Updated Windows, macOS, and Linux wheels to be compiled with OpenSSL 3.5.3.
  • We now build ppc64le manylinux wheels and publish them to PyPI.
  • We now build win_arm64 (Windows on Arm) wheels and publish them to PyPI.
  • Added support for free-threaded Python 3.14.
  • Removed the deprecated get_attribute_for_oid method on :class:~cryptography.x509.CertificateSigningRequest. Users should use :meth:~cryptography.x509.Attributes.get_attribute_for_oid instead.
  • Removed the deprecated CAST5, SEED, IDEA, and Blowfish classes from the cipher module. These are still available in :doc:/hazmat/decrepit/index.
  • In X.509, when performing a PSS signature with a SHA-3 hash, it is now encoded with the official NIST SHA3 OID.

.. _v45-0-7:

... (truncated)

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Additional Changes added

  • cryptography package | 43.0.3 → 46.0.3
  • RSA key size | 2048 → 3072 bits
  • RFC 5280 compliance | Added certificate extensions
  • Certificate storage | ./tls-* → ~/.local/share/codeflare/tls/
  • File permissions | Default → 0600 (secure)
  • Auto-generation mtls config| Manual → Automatic in wait_ready()
  • Auto-cleanup mtls config | Manual → Automatic in down()
  • Refresh capability | None → cluster.refresh_certificates()
  • Warning messages | None → Helpful warnings in connection methods
  • Unit tests | Updated for new behaviour

Verification

  • poetry build & pip install into your jupyter notebook
  • Run through the demo notebook 2_basic_interactive.ipynb
  • After cluster creation and execution of cluster.wait_ready() verify that files ca.crt tls.crt tls.key are create at /opt/app-root/src/.local/share/codeflare/tls/<clustername>-<namespace>
  • execution of the train function should work
  • after cluster.down() verify that the previously create files are removed

@dependabot dependabot bot added dependabot test-guided-notebooks Run PR check to verify Guided notebooks labels Oct 16, 2025
@openshift-ci openshift-ci bot requested a review from pawelpaszki October 16, 2025 22:10
@codeflare-machine-account codeflare-machine-account added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 16, 2025
Bumps [cryptography](https://github.com/pyca/cryptography) from 43.0.3 to 46.0.3.
- [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst)
- [Commits](pyca/cryptography@43.0.3...46.0.3)

---
updated-dependencies:
- dependency-name: cryptography
  dependency-version: 46.0.3
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@laurafitzgerald laurafitzgerald force-pushed the dependabot/pip/cryptography-46.0.3 branch from 7daaff6 to 0b0dcce Compare November 26, 2025 11:26
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 26, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

New changes are detected. LGTM label has been removed.

@laurafitzgerald laurafitzgerald self-assigned this Nov 26, 2025
@laurafitzgerald laurafitzgerald force-pushed the dependabot/pip/cryptography-46.0.3 branch from 0b0dcce to bac0fd2 Compare November 26, 2025 11:35
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Nov 26, 2025

Codecov Report

❌ Patch coverage is 47.28682% with 68 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.34%. Comparing base (8eac545) to head (38a22d3).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/codeflare_sdk/common/utils/generate_cert.py 44.95% 60 Missing ⚠️
src/codeflare_sdk/ray/cluster/cluster.py 57.89% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #931      +/-   ##
==========================================
- Coverage   94.13%   91.34%   -2.79%     
==========================================
  Files          24       24              
  Lines        2096     2206     +110     
==========================================
+ Hits         1973     2015      +42     
- Misses        123      191      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

redis_address: Optional[str] = None
redis_password_secret: Optional[Dict[str, str]] = None
external_storage_namespace: Optional[str] = None
cleanup_tls_certs: bool = True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be a new field or an env var? Only reason I'd veer towards an env var is the sheer number of params we already have in ClusterConfig

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree there's lots there. I think it's probably safe enough to attempt to delete the certs each time a cluster is deleted. They wont be needed after that anyway.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 28, 2025
@openshift-merge-robot
Copy link
Collaborator

rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kryanbeane kryanbeane removed the test-guided-notebooks Run PR check to verify Guided notebooks label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dependabot needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants