Core module returns core=false if wire folder symlinked

[chriswthomson]

This is definitely a quirk with our setup, but only started happening on one of the recent dev releases. We have the wire folder for installs symlinked to a single wire folder for easier upgrades.

After refactoring for AI started, going to Modules > Site in the nav started returning a list of all modules, while nothing appears for Modules > Core.

It looks to me as if the issue is that we're using 'wire3' as the directory name, so this line in ModulesInfo.php fails:

if($info['file']) $info['core'] = strpos($info['file'], $this->modules->coreModulesDir) !== false; // is it core?

It looks to me to be caused by the addition of this line in ModulesFiles.php:

if($this->wireIsLink) { $real = realpath($file); if($real !== false) $file = $real; }

Is the only solution here to use 'wire' as the directory name instead of 'wire3'?

[ryancramerdesign]

Good diagnosis, Chris. The realpath() call was added to getModuleFile() to handle symlinked /wire/ directories during file inclusion, but getModuleFile() is also the source of $info['file'] — the path stored in the modules info array. Once that path is resolved to the real target directory name (wire3), the coreModulesDir substring check (which still uses the symlink name wire) fails, so all core modules get misclassified as site modules.

The fix is to move the realpath() call out of getModuleFile() and into includeModuleFile(), just before the file is actually included. That's the only place where resolving the canonical path matters — everything else that uses the file path (core detection, compile skip check, display) should see the path as configured, not the resolved real path.

This has been fixed for the next dev release. In the meantime, using wire as the directory name (as you noted) is the workaround.

-Claude