Skip to content

Commit cd66ac0

Browse files
committed
Added unit test for angleBetween
1 parent 262668a commit cd66ac0

File tree

1 file changed

+16
-6
lines changed

1 file changed

+16
-6
lines changed

test/unit/math/p5.Vector.js

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,14 @@ suite('p5.Vector', function() {
120120
test('should not trip on rounding issues in 2D space', function() {
121121
var v1 = myp5.createVector(-11, -20);
122122
var v2 = myp5.createVector(-5.5, -10);
123-
expect(Math.abs(v1.angleBetween(v2))).to.be.closeTo(0, 0.00001);
123+
var res = v1.angleBetween(v2);
124+
//expect(Math.abs(v1.angleBetween(v2))).to.be.closeTo(0, 0.00001);
125+
expect(res).to.be.closeTo(0, 0.00001);
124126

125127
var v3 = myp5.createVector(-11, -20);
126128
var v4 = myp5.createVector(5.5, 10);
127129
expect(Math.abs(v3.angleBetween(v4))).to.be.closeTo(180, 0.00001);
130+
expect(v3.angleBetween(v4)).to.be.closeTo(180, 0.00001);
128131
});
129132

130133
test('should not trip on rounding issues in 3D space', function() {
@@ -140,7 +143,7 @@ suite('p5.Vector', function() {
140143
var v2 = myp5.createVector(2, 3, 4);
141144

142145
expect(Math.abs(v1.angleBetween(v2))).to.be.NaN; // jshint ignore:line
143-
expect(Math.abs(v2.angleBetween(v1))).to.be.NaN; // jshint ignore:line
146+
expect(v2.angleBetween(v1)).to.be.NaN; // jshint ignore:line
144147
});
145148
});
146149

@@ -856,7 +859,7 @@ suite('p5.Vector', function() {
856859
setup(function() {
857860
v1 = new p5.Vector(1, 0, 0);
858861
v2 = new p5.Vector(2, 2, 0);
859-
res = Math.abs(v1.angleBetween(v2));
862+
res = v1.angleBetween(v2);
860863
});
861864

862865
test('should be a Number', function() {
@@ -867,8 +870,9 @@ suite('p5.Vector', function() {
867870
test('should be 45 deg difference', function() {
868871
v1 = new p5.Vector(1, 0, 0);
869872
v2 = new p5.Vector(2, 2, 0);
870-
res = Math.abs(v1.angleBetween(v2));
873+
res = v1.angleBetween(v2);
871874
expect(res).to.be.closeTo(Math.PI / 4, 0.01);
875+
expect(v2.angleBetween(v1)).to.be.closeTo(-1 * Math.PI / 4, 0.01);
872876
});
873877
});
874878

@@ -885,8 +889,14 @@ suite('p5.Vector', function() {
885889
test('should be 135 deg difference', function() {
886890
v1 = new p5.Vector(2, 0, 0);
887891
v2 = new p5.Vector(-2, -2, 0);
888-
res = Math.abs(v1.angleBetween(v2));
889-
expect(res).to.be.closeTo(Math.PI / 2 + Math.PI / 4, 0.01);
892+
expect(v1.angleBetween(v2)).to.be.closeTo(
893+
-1 * (Math.PI / 2 + Math.PI / 4),
894+
0.01
895+
);
896+
expect(v2.angleBetween(v1)).to.be.closeTo(
897+
Math.PI / 2 + Math.PI / 4,
898+
0.01
899+
);
890900
});
891901

892902
test('should be commutative', function() {

0 commit comments

Comments
 (0)