Review update : Fixed select() issue with existing dropdown

Author: JimishF

lib/addons/p5.dom.js

@@ -528,10 +528,11 @@
 
   /**
    * Creates a dropdown menu <select></select> element in the DOM.
-   * It also helps to asssign select-box methods to p5.Element when selecting existing select box
+   * It also helps to assign select-box methods to p5.Element when selecting existing select box
    * @method createSelect
-   * @param {boolean} [multiple] true if dropdown should support multiple selections
-   * @return {Object|p5.Element} pointer to p5.Element holding created node
+   * @param {boolean} [multiple] true if dropdown should support multiple selections OR
+   * @param {Object  [P5.Element] if wrapping methods to existing select
+   * @return {Object|p5.Element} pointer to p5.Element holding created or existing node
    * @example
    * <div><code>
    * var sel;
@@ -555,17 +556,18 @@
    * </code></div>
    */
 
-  p5.prototype.createSelect = function(mult) {
-
-    if( typeof mult === 'object' && mult.elt.nodeName == 'SELECT' ){
-      var self = mult;
-      var elt = this.elt = mult.elt;
+  p5.prototype.createSelect = function() {
+    var elt,self;
+    var arg = arguments[0];
+    if( typeof arg === 'object' && arg.elt.nodeName == 'SELECT' ){
+      self = arg;
+      elt = this.elt = arg.elt;
     }else{
-      var elt = document.createElement('select');
-      if( mult && typeof mult === 'boolean' ){
+      elt = document.createElement('select');
+      if( arg && typeof arg === 'boolean' ){
         elt.setAttribute('multiple', 'true');
       }
-      var self = addElement(elt, this);
+      self = addElement(elt, this);
     }
     self.option = function(name, value){
       var opt = document.createElement('option');
@@ -586,7 +588,7 @@
         }
         return this;
       }else{
-        if (mult){
+        if (arg){
           for (var i = 0; i < this.elt.selectedOptions.length; i++){
             arr.push(this.elt.selectedOptions[i].value);
           }