Skip to content

Commit 7ad9d98

Browse files
committed
Fixing callbacks in preload()
1 parent 5f2ed8d commit 7ad9d98

File tree

3 files changed

+9
-11
lines changed

3 files changed

+9
-11
lines changed

examples/loadingscreen/preload_success_callbacks.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -33,15 +33,15 @@ function successFont() {
3333

3434
function preload() {
3535
// try with callbacks
36-
myJson = loadJSON('http://api.openweathermap.org/data/2.5/weather?q=London,uk', successJSON);
36+
myJson = loadJSON('test.json', successJSON);
3737
banana = loadImage('banana.png', successImage);
3838
strings = loadStrings('test.txt', successStrings);
3939
xml = loadXML('test.xml', successXML);
4040
myTable = loadTable('mammals.csv', 'csv', 'header', successTable);
4141
myFont = loadFont('AvenirNextLTPro-Demi.otf', successFont);
4242

4343
// try with no callbacks
44-
myJson2 = loadJSON('http://api.openweathermap.org/data/2.5/weather?q=London,uk');
44+
myJson2 = loadJSON('test.json');
4545
banana2 = loadImage('banana.png');
4646
strings2 = loadStrings('test.txt');
4747
xml2 = loadXML('test.xml');
@@ -62,8 +62,8 @@ function draw() {
6262
image(banana, 0, y);
6363
image(banana2, 0, y += 50);
6464

65-
text(myJson.main.humidity, 0, y += 50);
66-
text(myJson2.main.humidity, 0, y += 50);
65+
text(myJson.a, 0, y += 50);
66+
text(myJson2.a, 0, y += 50);
6767

6868
text(strings.length, 0, y += 50);
6969
text(strings2.length, 0, y += 50);

src/image/loading_displaying.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,7 @@ require('../core/error_helpers');
6161
p5.prototype.loadImage = function(path, successCallback, failureCallback) {
6262
var img = new Image();
6363
var pImg = new p5.Image(1, 1, this);
64-
var decrementPreload = p5._getDecrementPreload.call(this,
65-
path, successCallback, failureCallback);
64+
var decrementPreload = p5._getDecrementPreload.apply(this, arguments);
6665

6766
img.onload = function() {
6867
pImg.width = pImg.canvas.width = img.width;

src/io/files.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -88,8 +88,7 @@ p5._getDecrementPreload = function() {
8888
p5.prototype.loadFont = function(path, onSuccess, onError) {
8989

9090
var p5Font = new p5.Font(this);
91-
var decrementPreload = p5._getDecrementPreload.call(this,
92-
path, onSuccess, onError);
91+
var decrementPreload = p5._getDecrementPreload.apply(this, arguments);
9392

9493
opentype.load(path, function(err, font) {
9594

@@ -292,7 +291,7 @@ p5.prototype.loadJSON = function() {
292291
p5.prototype.loadStrings = function (path, callback) {
293292
var ret = [];
294293
var req = new XMLHttpRequest();
295-
var decrementPreload = p5._getDecrementPreload.call(this, path, callback);
294+
var decrementPreload = p5._getDecrementPreload.apply(this, arguments);
296295

297296
req.addEventListener('error', function () {
298297
console.log('An error occurred loading strings: ' + path);
@@ -407,7 +406,7 @@ p5.prototype.loadTable = function (path) {
407406
var header = false;
408407
var sep = ',';
409408
var separatorSet = false;
410-
var decrementPreload = p5._getDecrementPreload.call(this, path);
409+
var decrementPreload = p5._getDecrementPreload.apply(this, arguments);
411410

412411
for (var i = 1; i < arguments.length; i++) {
413412
if ((typeof(arguments[i]) === 'function') &&
@@ -635,7 +634,7 @@ function makeObject(row, headers) {
635634
*/
636635
p5.prototype.loadXML = function(path, callback) {
637636
var ret = document.implementation.createDocument(null, null);
638-
var decrementPreload = p5._getDecrementPreload.call(this, path, callback);
637+
var decrementPreload = p5._getDecrementPreload.apply(this, arguments);
639638

640639
reqwest({
641640
url: path,

0 commit comments

Comments
 (0)