Merge pull request #8083 from perminder-17/fontBounds-NaN

textToContours is broken under textAlign(CENTER,CENTER) and use linebreak

Author: davepagurek

.vscode/settings.json

@@ -10,4 +10,4 @@
 	"editor.formatOnSave": false,
   "editor.codeActionsOnSave": {},
 	"javascript.format.enable": false
-}
+}

lib/empty-example/sketch.js

@@ -4,4 +4,4 @@ function setup() {
 
  function draw() {
    // put drawing code here
- }
+ }

src/type/textCore.js

@@ -1905,12 +1905,13 @@ function textCore(p5, fn) {
 
     // adjust the bounding boxes based on horiz. text alignment
     if (lines.length > 1) {
-      // Call the 2D mode version: the WebGL mode version does additional
-      // alignment adjustments to account for how WebGL renders text.
-      boxes.forEach(bb =>
-        bb.x += p5.Renderer2D.prototype._xAlignOffset
-          .call(this, textAlign, width)
-      );
+      // When width is not provided (e.g., fontBounds path), fall back to the widest line.
+      const maxWidth = boxes.reduce((m, b) => Math.max(m, b.w || 0), 0);
+
+      boxes.forEach((bb) => {
+          const w = (width ?? maxWidth);
+          bb.x += p5.Renderer2D.prototype._xAlignOffset.call(this, textAlign, w);
+        });
     }
 
     // adjust the bounding boxes based on vert. text alignment

test/unit/type/p5.Font.js

@@ -40,6 +40,16 @@ suite('p5.Font', function () {
     assert.property(bbox, 'h');
   });
 
+   test('fontBounds no NaN (multiline + CENTER)', async () => {
+     const pFont = await myp5.loadFont(fontFile);
+     myp5.textAlign(myp5.CENTER, myp5.CENTER);
+     const b = pFont.fontBounds('Hello,\nWorld!', 50, 50, 24);
+     expect(b.x).not.toBeNaN();
+     expect(b.y).not.toBeNaN();
+     expect(b.w).not.toBeNaN();
+     expect(b.h).not.toBeNaN();
+  });
+
   suite('textToPoints', () => {
     test('contains no NaNs', async () => {
       const pFont = await myp5.loadFont(fontFile);