Skip to content

Commit 5b85378

Browse files
author
lauren mccarthy
committed
switching to false instead of falsey check issue #366 
1 parent bea9f9a commit 5b85378

File tree

4 files changed

+31
-31
lines changed

4 files changed

+31
-31
lines changed

‎lib/p5.js‎

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3056,19 +3056,19 @@ var inputmouse = function (require, core, constants) {
30563056
if (!this.isMousePressed) {
30573057
if (typeof context.mouseMoved === 'function') {
30583058
executeDefault = context.mouseMoved(e);
3059-
if (executeDefault !== undefined && !executeDefault) {
3059+
if (executeDefault === false) {
30603060
e.preventDefault();
30613061
}
30623062
}
30633063
} else {
30643064
if (typeof context.mouseDragged === 'function') {
30653065
executeDefault = context.mouseDragged(e);
3066-
if (executeDefault !== undefined && !executeDefault) {
3066+
if (executeDefault === false) {
30673067
e.preventDefault();
30683068
}
30693069
} else if (typeof context.touchMoved === 'function') {
30703070
executeDefault = context.touchMoved(e);
3071-
if (!executeDefault) {
3071+
if (executeDefault === false) {
30723072
e.preventDefault();
30733073
}
30743074
this._updateTouchCoords(e);
@@ -3083,12 +3083,12 @@ var inputmouse = function (require, core, constants) {
30833083
this._setMouseButton(e);
30843084
if (typeof context.mousePressed === 'function') {
30853085
executeDefault = context.mousePressed(e);
3086-
if (executeDefault !== undefined && !executeDefault) {
3086+
if (executeDefault === false) {
30873087
e.preventDefault();
30883088
}
30893089
} else if (typeof context.touchStarted === 'function') {
30903090
executeDefault = context.touchStarted(e);
3091-
if (!executeDefault) {
3091+
if (executeDefault === false) {
30923092
e.preventDefault();
30933093
}
30943094
this._updateTouchCoords(e);
@@ -3101,12 +3101,12 @@ var inputmouse = function (require, core, constants) {
31013101
this._setProperty('mouseIsPressed', false);
31023102
if (typeof context.mouseReleased === 'function') {
31033103
executeDefault = context.mouseReleased(e);
3104-
if (executeDefault !== undefined && !executeDefault) {
3104+
if (executeDefault === false) {
31053105
e.preventDefault();
31063106
}
31073107
} else if (typeof context.touchEnded === 'function') {
31083108
executeDefault = context.touchEnded(e);
3109-
if (!executeDefault) {
3109+
if (executeDefault === false) {
31103110
e.preventDefault();
31113111
}
31123112
this._updateTouchCoords(e);
@@ -3116,7 +3116,7 @@ var inputmouse = function (require, core, constants) {
31163116
var context = this._isGlobal ? window : this;
31173117
if (typeof context.mouseClicked === 'function') {
31183118
var executeDefault = context.mouseClicked(e);
3119-
if (executeDefault !== undefined && !executeDefault) {
3119+
if (executeDefault === false) {
31203120
e.preventDefault();
31213121
}
31223122
}
@@ -3125,7 +3125,7 @@ var inputmouse = function (require, core, constants) {
31253125
var context = this._isGlobal ? window : this;
31263126
if (typeof context.mouseWheel === 'function') {
31273127
var executeDefault = context.mouseWheel(e);
3128-
if (!executeDefault) {
3128+
if (executeDefault === false) {
31293129
e.preventDefault();
31303130
}
31313131
}
@@ -3194,12 +3194,12 @@ var inputtouch = function (require, core) {
31943194
this._updateTouchCoords(e);
31953195
if (typeof context.touchStarted === 'function') {
31963196
executeDefault = context.touchStarted(e);
3197-
if (!executeDefault) {
3197+
if (executeDefault === false) {
31983198
e.preventDefault();
31993199
}
32003200
} else if (typeof context.mousePressed === 'function') {
32013201
executeDefault = context.mousePressed(e);
3202-
if (!executeDefault) {
3202+
if (executeDefault === false) {
32033203
e.preventDefault();
32043204
}
32053205
}
@@ -3210,12 +3210,12 @@ var inputtouch = function (require, core) {
32103210
this._updateTouchCoords(e);
32113211
if (typeof context.touchMoved === 'function') {
32123212
executeDefault = context.touchMoved(e);
3213-
if (!executeDefault) {
3213+
if (executeDefault === false) {
32143214
e.preventDefault();
32153215
}
32163216
} else if (typeof context.mouseDragged === 'function') {
32173217
executeDefault = context.mouseDragged(e);
3218-
if (!executeDefault) {
3218+
if (executeDefault === false) {
32193219
e.preventDefault();
32203220
}
32213221
this._updateMouseCoords(e);
@@ -3226,12 +3226,12 @@ var inputtouch = function (require, core) {
32263226
var executeDefault;
32273227
if (typeof context.touchEnded === 'function') {
32283228
executeDefault = context.touchEnded(e);
3229-
if (!executeDefault) {
3229+
if (executeDefault === false) {
32303230
e.preventDefault();
32313231
}
32323232
} else if (typeof context.mouseReleased === 'function') {
32333233
executeDefault = context.mouseReleased(e);
3234-
if (!executeDefault) {
3234+
if (executeDefault === false) {
32353235
e.preventDefault();
32363236
}
32373237
this._updateMouseCoords(e);

‎lib/p5.min.js‎

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

‎src/input/mouse.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -201,20 +201,20 @@ define(function (require) {
201201
if (!this.isMousePressed) {
202202
if (typeof context.mouseMoved === 'function') {
203203
executeDefault = context.mouseMoved(e);
204-
if(executeDefault !== undefined && !executeDefault) {
204+
if(executeDefault === false) {
205205
e.preventDefault();
206206
}
207207
}
208208
}
209209
else {
210210
if (typeof context.mouseDragged === 'function') {
211211
executeDefault = context.mouseDragged(e);
212-
if(executeDefault !== undefined && !executeDefault) {
212+
if(executeDefault === false) {
213213
e.preventDefault();
214214
}
215215
} else if (typeof context.touchMoved === 'function') {
216216
executeDefault = context.touchMoved(e);
217-
if(!executeDefault) {
217+
if(executeDefault === false) {
218218
e.preventDefault();
219219
}
220220
this._updateTouchCoords(e);
@@ -260,12 +260,12 @@ define(function (require) {
260260
this._setMouseButton(e);
261261
if (typeof context.mousePressed === 'function') {
262262
executeDefault = context.mousePressed(e);
263-
if(executeDefault !== undefined && !executeDefault) {
263+
if(executeDefault === false) {
264264
e.preventDefault();
265265
}
266266
} else if (typeof context.touchStarted === 'function') {
267267
executeDefault = context.touchStarted(e);
268-
if(!executeDefault) {
268+
if(executeDefault === false) {
269269
e.preventDefault();
270270
}
271271
this._updateTouchCoords(e);
@@ -307,12 +307,12 @@ define(function (require) {
307307
this._setProperty('mouseIsPressed', false);
308308
if (typeof context.mouseReleased === 'function') {
309309
executeDefault = context.mouseReleased(e);
310-
if(executeDefault !== undefined && !executeDefault) {
310+
if(executeDefault === false) {
311311
e.preventDefault();
312312
}
313313
} else if (typeof context.touchEnded === 'function') {
314314
executeDefault = context.touchEnded(e);
315-
if(!executeDefault) {
315+
if(executeDefault === false) {
316316
e.preventDefault();
317317
}
318318
this._updateTouchCoords(e);
@@ -350,7 +350,7 @@ define(function (require) {
350350
var context = this._isGlobal ? window : this;
351351
if (typeof context.mouseClicked === 'function') {
352352
var executeDefault = context.mouseClicked(e);
353-
if(executeDefault !== undefined && !executeDefault) {
353+
if(executeDefault === false) {
354354
e.preventDefault();
355355
}
356356
}
@@ -371,7 +371,7 @@ define(function (require) {
371371
var context = this._isGlobal ? window : this;
372372
if (typeof context.mouseWheel === 'function') {
373373
var executeDefault = context.mouseWheel(e);
374-
if(!executeDefault) {
374+
if(executeDefault === false) {
375375
e.preventDefault();
376376
}
377377
}

‎src/input/touch.js‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,12 @@ define(function (require) {
9595
this._updateTouchCoords(e);
9696
if(typeof context.touchStarted === 'function') {
9797
executeDefault = context.touchStarted(e);
98-
if(!executeDefault) {
98+
if(executeDefault === false) {
9999
e.preventDefault();
100100
}
101101
} else if (typeof context.mousePressed === 'function') {
102102
executeDefault = context.mousePressed(e);
103-
if(!executeDefault) {
103+
if(executeDefault === false) {
104104
e.preventDefault();
105105
}
106106
//this._setMouseButton(e);
@@ -120,12 +120,12 @@ define(function (require) {
120120
this._updateTouchCoords(e);
121121
if (typeof context.touchMoved === 'function') {
122122
executeDefault = context.touchMoved(e);
123-
if(!executeDefault) {
123+
if(executeDefault === false) {
124124
e.preventDefault();
125125
}
126126
} else if (typeof context.mouseDragged === 'function') {
127127
executeDefault = context.mouseDragged(e);
128-
if(!executeDefault) {
128+
if(executeDefault === false) {
129129
e.preventDefault();
130130
}
131131
this._updateMouseCoords(e);
@@ -144,12 +144,12 @@ define(function (require) {
144144
var executeDefault;
145145
if (typeof context.touchEnded === 'function') {
146146
executeDefault = context.touchEnded(e);
147-
if(!executeDefault) {
147+
if(executeDefault === false) {
148148
e.preventDefault();
149149
}
150150
} else if (typeof context.mouseReleased === 'function') {
151151
executeDefault = context.mouseReleased(e);
152-
if(!executeDefault) {
152+
if(executeDefault === false) {
153153
e.preventDefault();
154154
}
155155
this._updateMouseCoords(e);

0 commit comments

Comments
 (0)