From 0dd35e897b2e2d875f4a42a00ad99c1b01ad8676 Mon Sep 17 00:00:00 2001 From: Aman Varshney Date: Fri, 1 May 2026 21:15:38 +0530 Subject: [PATCH] fix(ui): keep readable text contrast on Discard edits hover The "Discard edits" button used `variant="outline"`, which injects `hover:text-accent-foreground`. The local className overrode the hover background (`hover:bg-amber-200`) but not the hover text color, so on hover the text turned the light accent-foreground color over an amber background, producing poor contrast. Drop `variant="outline"` (default variant has no hover text-color rule) and add `border` to the className. This matches the sibling "Save edits" button's pattern. Text now stays `text-amber-950` in both default and hover states. --- ui/studio/views/table/ActiveTableView.tsx | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ui/studio/views/table/ActiveTableView.tsx b/ui/studio/views/table/ActiveTableView.tsx index cdf7f11b..5e39d94b 100644 --- a/ui/studio/views/table/ActiveTableView.tsx +++ b/ui/studio/views/table/ActiveTableView.tsx @@ -1695,9 +1695,8 @@ export function ActiveTableView(_props: ViewProps) { ? `${discardWiggleAnimationKey}-${discardWiggleCount}` : undefined } - variant="outline" className={cn( - "h-9 border-amber-300 bg-amber-100 px-4 font-sans text-amber-950 hover:border-amber-400 hover:bg-amber-200 motion-safe:origin-center motion-safe:will-change-transform", + "h-9 border border-amber-300 bg-amber-100 px-4 font-sans text-amber-950 hover:border-amber-400 hover:bg-amber-200 motion-safe:origin-center motion-safe:will-change-transform", discardWiggleAnimationClassName, )} onClick={() => setDiscardDialogOpen(true)}