From a2ed7f597a6fc33f5b39cd3be51479916bad7fdb Mon Sep 17 00:00:00 2001 From: pkaczmarek Date: Mon, 27 Apr 2026 07:28:29 +0200 Subject: [PATCH 1/3] New adapter: BeOp --- .../prebid/server/bidder/beop/BeopBidder.java | 156 ++++++++++ .../openrtb/ext/request/beop/ExtImpBeop.java | 19 ++ .../config/bidder/BeopConfiguration.java | 41 +++ src/main/resources/bidder-config/beop.yaml | 17 + .../resources/static/bidder-params/beop.json | 37 +++ .../server/bidder/beop/BeopBidderTest.java | 292 ++++++++++++++++++ .../java/org/prebid/server/it/BeopTest.java | 32 ++ .../beop/test-auction-beop-request.json | 23 ++ .../beop/test-auction-beop-response.json | 38 +++ .../openrtb2/beop/test-beop-bid-request.json | 52 ++++ .../openrtb2/beop/test-beop-bid-response.json | 21 ++ .../server/it/test-application.properties | 2 + 12 files changed, 730 insertions(+) create mode 100644 src/main/java/org/prebid/server/bidder/beop/BeopBidder.java create mode 100644 src/main/java/org/prebid/server/proto/openrtb/ext/request/beop/ExtImpBeop.java create mode 100644 src/main/java/org/prebid/server/spring/config/bidder/BeopConfiguration.java create mode 100644 src/main/resources/bidder-config/beop.yaml create mode 100644 src/main/resources/static/bidder-params/beop.json create mode 100644 src/test/java/org/prebid/server/bidder/beop/BeopBidderTest.java create mode 100644 src/test/java/org/prebid/server/it/BeopTest.java create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/beop/test-auction-beop-request.json create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/beop/test-auction-beop-response.json create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/beop/test-beop-bid-request.json create mode 100644 src/test/resources/org/prebid/server/it/openrtb2/beop/test-beop-bid-response.json diff --git a/src/main/java/org/prebid/server/bidder/beop/BeopBidder.java b/src/main/java/org/prebid/server/bidder/beop/BeopBidder.java new file mode 100644 index 00000000000..b0e88f6fc0d --- /dev/null +++ b/src/main/java/org/prebid/server/bidder/beop/BeopBidder.java @@ -0,0 +1,156 @@ +package org.prebid.server.bidder.beop; + +import com.fasterxml.jackson.core.type.TypeReference; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import org.apache.commons.collections4.CollectionUtils; +import org.apache.commons.lang3.StringUtils; +import org.apache.http.client.utils.URIBuilder; +import org.prebid.server.bidder.Bidder; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.exception.PreBidException; +import org.prebid.server.json.DecodeException; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.proto.openrtb.ext.ExtPrebid; +import org.prebid.server.proto.openrtb.ext.request.beop.ExtImpBeop; +import org.prebid.server.proto.openrtb.ext.response.BidType; +import org.prebid.server.util.BidderUtil; +import org.prebid.server.util.HttpUtil; + +import java.net.URISyntaxException; +import java.util.ArrayList; +import java.util.Collection; +import java.util.List; +import java.util.Objects; + +public class BeopBidder implements Bidder { + + private static final TypeReference> BEOP_EXT_TYPE_REFERENCE = new TypeReference<>() { + }; + + private final String endpointUrl; + private final JacksonMapper mapper; + + public BeopBidder(String endpointUrl, JacksonMapper mapper) { + this.endpointUrl = HttpUtil.validateUrl(Objects.requireNonNull(endpointUrl)); + this.mapper = Objects.requireNonNull(mapper); + } + + @Override + public Result>> makeHttpRequests(BidRequest bidRequest) { + final List imps = bidRequest.getImp(); + if (CollectionUtils.isEmpty(imps)) { + return Result.withError(BidderError.badInput("No impressions provided")); + } + + final ExtImpBeop extImpBeop; + try { + extImpBeop = parseImpExt(imps.getFirst()); + } catch (PreBidException e) { + return Result.withError(BidderError.badInput(e.getMessage())); + } + + final String resolvedUrl; + try { + resolvedUrl = buildEndpointUrl(extImpBeop); + } catch (PreBidException e) { + return Result.withError(BidderError.badInput(e.getMessage())); + } + + return Result.withValue(BidderUtil.defaultRequest(bidRequest, resolvedUrl, mapper)); + } + + private ExtImpBeop parseImpExt(Imp imp) { + try { + return mapper.mapper().convertValue(imp.getExt(), BEOP_EXT_TYPE_REFERENCE).getBidder(); + } catch (IllegalArgumentException e) { + throw new PreBidException("ext.bidder not provided: " + e.getMessage()); + } + } + + private String buildEndpointUrl(ExtImpBeop ext) { + final URIBuilder uriBuilder; + try { + uriBuilder = new URIBuilder(endpointUrl); + } catch (URISyntaxException e) { + throw new PreBidException("Invalid endpoint URL: " + e.getMessage()); + } + + final String pid = StringUtils.trimToNull(ext.getBeopPublisherId()); + if (StringUtils.isNotEmpty(pid)) { + uriBuilder.addParameter("pid", pid); + } + + final String nid = StringUtils.trimToNull(ext.getBeopNetworkId()); + if (StringUtils.isNotEmpty(nid)) { + uriBuilder.addParameter("nid", nid); + } + + final String nptnid = StringUtils.trimToNull(ext.getBeopNetworkPartnerId()); + if (StringUtils.isNotEmpty(nptnid)) { + uriBuilder.addParameter("nptnid", nptnid); + } + + return uriBuilder.toString(); + } + + @Override + public Result> makeBids(BidderCall httpCall, BidRequest bidRequest) { + final BidResponse bidResponse; + try { + bidResponse = mapper.decodeValue(httpCall.getResponse().getBody(), BidResponse.class); + } catch (DecodeException e) { + return Result.withError(BidderError.badServerResponse(e.getMessage())); + } + + if (bidResponse == null || CollectionUtils.isEmpty(bidResponse.getSeatbid())) { + return Result.empty(); + } + + final List errors = new ArrayList<>(); + final List bids = extractBids(bidResponse, errors); + return Result.of(bids, errors); + } + + private static List extractBids(BidResponse bidResponse, List errors) { + return bidResponse.getSeatbid().stream() + .filter(Objects::nonNull) + .map(SeatBid::getBid) + .filter(Objects::nonNull) + .flatMap(Collection::stream) + .filter(Objects::nonNull) + .map(bid -> makeBidderBid(bid, bidResponse.getCur(), errors)) + .filter(Objects::nonNull) + .toList(); + } + + private static BidderBid makeBidderBid(Bid bid, String currency, List errors) { + try { + return BidderBid.of(bid, resolveBidType(bid), currency); + } catch (PreBidException e) { + errors.add(BidderError.badServerResponse(e.getMessage())); + return null; + } + } + + private static BidType resolveBidType(Bid bid) { + final Integer mtype = bid.getMtype(); + if (mtype == null) { + throw new PreBidException( + "Failed to parse bid mtype for impression \"%s\"".formatted(bid.getImpid())); + } + return switch (mtype) { + case 1 -> BidType.banner; + case 2 -> BidType.video; + default -> throw new PreBidException( + "Failed to parse bid mtype for impression \"%s\"".formatted(bid.getImpid())); + }; + } +} diff --git a/src/main/java/org/prebid/server/proto/openrtb/ext/request/beop/ExtImpBeop.java b/src/main/java/org/prebid/server/proto/openrtb/ext/request/beop/ExtImpBeop.java new file mode 100644 index 00000000000..054e4cda6f8 --- /dev/null +++ b/src/main/java/org/prebid/server/proto/openrtb/ext/request/beop/ExtImpBeop.java @@ -0,0 +1,19 @@ +package org.prebid.server.proto.openrtb.ext.request.beop; + +import com.fasterxml.jackson.annotation.JsonAlias; +import com.fasterxml.jackson.annotation.JsonProperty; +import lombok.Value; + +@Value(staticConstructor = "of") +public class ExtImpBeop { + + @JsonProperty("pid") + String beopPublisherId; + + @JsonProperty("nid") + String beopNetworkId; + + @JsonProperty("nptnid") + @JsonAlias("ntpnid") + String beopNetworkPartnerId; +} diff --git a/src/main/java/org/prebid/server/spring/config/bidder/BeopConfiguration.java b/src/main/java/org/prebid/server/spring/config/bidder/BeopConfiguration.java new file mode 100644 index 00000000000..a0f94bee00b --- /dev/null +++ b/src/main/java/org/prebid/server/spring/config/bidder/BeopConfiguration.java @@ -0,0 +1,41 @@ +package org.prebid.server.spring.config.bidder; + +import org.prebid.server.bidder.BidderDeps; +import org.prebid.server.bidder.beop.BeopBidder; +import org.prebid.server.json.JacksonMapper; +import org.prebid.server.spring.config.bidder.model.BidderConfigurationProperties; +import org.prebid.server.spring.config.bidder.util.BidderDepsAssembler; +import org.prebid.server.spring.config.bidder.util.UsersyncerCreator; +import org.prebid.server.spring.env.YamlPropertySourceFactory; +import org.springframework.beans.factory.annotation.Value; +import org.springframework.boot.context.properties.ConfigurationProperties; +import org.springframework.context.annotation.Bean; +import org.springframework.context.annotation.Configuration; +import org.springframework.context.annotation.PropertySource; + +import jakarta.validation.constraints.NotBlank; + +@Configuration +@PropertySource(value = "classpath:/bidder-config/beop.yaml", factory = YamlPropertySourceFactory.class) +public class BeopConfiguration { + + private static final String BIDDER_NAME = "beop"; + + @Bean("beopConfigurationProperties") + @ConfigurationProperties("adapters.beop") + BidderConfigurationProperties configurationProperties() { + return new BidderConfigurationProperties(); + } + + @Bean + BidderDeps beopBidderDeps(BidderConfigurationProperties beopConfigurationProperties, + @NotBlank @Value("${external-url}") String externalUrl, + JacksonMapper mapper) { + + return BidderDepsAssembler.forBidder(BIDDER_NAME) + .withConfig(beopConfigurationProperties) + .usersyncerCreator(UsersyncerCreator.create(externalUrl)) + .bidderCreator(config -> new BeopBidder(config.getEndpoint(), mapper)) + .assemble(); + } +} diff --git a/src/main/resources/bidder-config/beop.yaml b/src/main/resources/bidder-config/beop.yaml new file mode 100644 index 00000000000..916f0f4a87d --- /dev/null +++ b/src/main/resources/bidder-config/beop.yaml @@ -0,0 +1,17 @@ +adapters: + beop: + endpoint: "https://hb.collectiveaudience.co/rtb/bid" + ortb-version: "2.6" + endpoint-compression: gzip + geoscope: + - USA + meta-info: + maintainer-email: "tech@collectiveaudience.co" + app-media-types: + - banner + - video + site-media-types: + - banner + - video + supported-vendors: [] + vendor-id: 666 diff --git a/src/main/resources/static/bidder-params/beop.json b/src/main/resources/static/bidder-params/beop.json new file mode 100644 index 00000000000..5f5bf8db4bf --- /dev/null +++ b/src/main/resources/static/bidder-params/beop.json @@ -0,0 +1,37 @@ +{ + "$schema": "http://json-schema.org/draft-04/schema#", + "title": "BeOp Adapter Params", + "description": "A schema which validates params accepted by the BeOp adapter", + "type": "object", + "properties": { + "pid": { + "type": "string", + "description": "Beop publisher ID" + }, + "nid": { + "type": "string", + "description": "Beop Network ID" + }, + "nptnid": { + "type": "string", + "description": "Network partner ID" + }, + "ntpnid": { + "type": "string", + "description": "Legacy alias for network partner ID; use nptnid" + } + }, + "oneOf": [ + { + "required": [ + "pid" + ] + }, + { + "required": [ + "nid", + "nptnid" + ] + } + ] +} diff --git a/src/test/java/org/prebid/server/bidder/beop/BeopBidderTest.java b/src/test/java/org/prebid/server/bidder/beop/BeopBidderTest.java new file mode 100644 index 00000000000..0bdac5576c6 --- /dev/null +++ b/src/test/java/org/prebid/server/bidder/beop/BeopBidderTest.java @@ -0,0 +1,292 @@ +package org.prebid.server.bidder.beop; + +import com.fasterxml.jackson.core.JsonProcessingException; +import com.fasterxml.jackson.databind.node.ObjectNode; +import com.iab.openrtb.request.BidRequest; +import com.iab.openrtb.request.Imp; +import com.iab.openrtb.response.Bid; +import com.iab.openrtb.response.BidResponse; +import com.iab.openrtb.response.SeatBid; +import org.junit.jupiter.api.Test; +import org.prebid.server.VertxTest; +import org.prebid.server.bidder.model.BidderBid; +import org.prebid.server.bidder.model.BidderCall; +import org.prebid.server.bidder.model.BidderError; +import org.prebid.server.bidder.model.HttpRequest; +import org.prebid.server.bidder.model.HttpResponse; +import org.prebid.server.bidder.model.Result; +import org.prebid.server.proto.openrtb.ext.ExtPrebid; +import org.prebid.server.proto.openrtb.ext.request.beop.ExtImpBeop; +import org.prebid.server.proto.openrtb.ext.response.BidType; + +import java.util.List; + +import static org.assertj.core.api.Assertions.assertThat; +import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException; + +public class BeopBidderTest extends VertxTest { + + private static final String ENDPOINT_URL = "https://test.com/test"; + + private final BeopBidder target = new BeopBidder(ENDPOINT_URL, jacksonMapper); + + @Test + public void creationShouldFailOnInvalidEndpointUrl() { + assertThatIllegalArgumentException().isThrownBy(() -> new BeopBidder("invalid_url", jacksonMapper)); + } + + @Test + public void makeHttpRequestsShouldReturnErrorWhenRequestHasNoImps() { + // given + final BidRequest bidRequest = BidRequest.builder().build(); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).containsExactly(BidderError.badInput("No impressions provided")); + } + + @Test + public void makeHttpRequestsShouldReturnErrorWhenImpExtCouldNotBeParsed() { + // given + final BidRequest bidRequest = BidRequest.builder() + .imp(List.of(Imp.builder() + .ext(mapper.valueToTree(ExtPrebid.of(null, mapper.createArrayNode()))) + .build())) + .build(); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).hasSize(1) + .extracting(BidderError::getMessage) + .allMatch(message -> message.startsWith("ext.bidder not provided:")); + } + + @Test + public void makeHttpRequestsShouldCreateRequestWithPidInUri() { + // given + final BidRequest bidRequest = givenBidRequest(givenImp(ExtImpBeop.of("publisherId", null, null))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1) + .extracting(HttpRequest::getUri) + .containsExactly(ENDPOINT_URL + "?pid=publisherId"); + } + + @Test + public void makeHttpRequestsShouldCreateRequestWithNidAndNptnidInUri() { + // given + final BidRequest bidRequest = givenBidRequest(givenImp(ExtImpBeop.of(null, "networkId", "partnerId"))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1) + .extracting(HttpRequest::getUri) + .containsExactly(ENDPOINT_URL + "?nid=networkId&nptnid=partnerId"); + } + + @Test + public void makeHttpRequestsShouldAcceptLegacyNtpnidAlias() { + // given + final ObjectNode bidderNode = mapper.createObjectNode() + .put("nid", "networkId") + .put("ntpnid", "legacyPartnerId"); + final ObjectNode ext = mapper.createObjectNode(); + ext.set("bidder", bidderNode); + + final Imp imp = Imp.builder() + .id("imp-1") + .ext(ext) + .build(); + final BidRequest bidRequest = givenBidRequest(imp); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1) + .extracting(HttpRequest::getUri) + .containsExactly(ENDPOINT_URL + "?nid=networkId&nptnid=legacyPartnerId"); + } + + @Test + public void makeHttpRequestsShouldCreateRequestWithOriginalPayload() { + // given + final BidRequest bidRequest = givenBidRequest(givenImp(ExtImpBeop.of("publisherId", null, null))); + + // when + final Result>> result = target.makeHttpRequests(bidRequest); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1) + .extracting(httpRequest -> mapper.readValue(httpRequest.getBody(), BidRequest.class)) + .containsOnly(bidRequest); + } + + @Test + public void makeBidsShouldReturnErrorIfResponseBodyCouldNotBeParsed() { + // given + final BidderCall httpCall = givenHttpCall("invalid"); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).hasSize(1) + .allSatisfy(error -> assertThat(error.getType()).isEqualTo(BidderError.Type.bad_server_response)); + } + + @Test + public void makeBidsShouldReturnEmptyResultIfBidResponseIsNull() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall(mapper.writeValueAsString(null)); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnEmptyResultIfSeatBidIsNull() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + mapper.writeValueAsString(BidResponse.builder().build())); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).isEmpty(); + } + + @Test + public void makeBidsShouldReturnBannerBidIfMTypeIsOne() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + mapper.writeValueAsString(givenBidResponse(Bid.builder().impid("imp-1").mtype(1).build()))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1) + .extracting(BidderBid::getType) + .containsExactly(BidType.banner); + } + + @Test + public void makeBidsShouldReturnVideoBidIfMTypeIsTwo() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + mapper.writeValueAsString(givenBidResponse(Bid.builder().impid("imp-1").mtype(2).build()))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getErrors()).isEmpty(); + assertThat(result.getValue()).hasSize(1) + .extracting(BidderBid::getType) + .containsExactly(BidType.video); + } + + @Test + public void makeBidsShouldReturnErrorForBidWithoutMType() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + mapper.writeValueAsString(givenBidResponse(Bid.builder().impid("imp-1").build()))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).hasSize(1) + .extracting(BidderError::getMessage) + .containsExactly("Failed to parse bid mtype for impression \"imp-1\""); + } + + @Test + public void makeBidsShouldReturnErrorForBidWithUnsupportedMType() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + mapper.writeValueAsString(givenBidResponse(Bid.builder().impid("imp-1").mtype(3).build()))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).isEmpty(); + assertThat(result.getErrors()).hasSize(1) + .extracting(BidderError::getMessage) + .containsExactly("Failed to parse bid mtype for impression \"imp-1\""); + } + + @Test + public void makeBidsShouldReturnValidBidsAndErrorsForMixedMTypes() throws JsonProcessingException { + // given + final BidderCall httpCall = givenHttpCall( + mapper.writeValueAsString(givenBidResponse( + Bid.builder().impid("imp-1").mtype(1).build(), + Bid.builder().impid("imp-2").mtype(2).build(), + Bid.builder().impid("imp-3").mtype(3).build()))); + + // when + final Result> result = target.makeBids(httpCall, null); + + // then + assertThat(result.getValue()).hasSize(2) + .extracting(BidderBid::getType) + .containsExactly(BidType.banner, BidType.video); + assertThat(result.getErrors()).hasSize(1) + .extracting(BidderError::getMessage) + .containsExactly("Failed to parse bid mtype for impression \"imp-3\""); + } + + private static BidRequest givenBidRequest(Imp... imps) { + return BidRequest.builder().imp(List.of(imps)).build(); + } + + private static Imp givenImp(ExtImpBeop extImpBeop) { + return Imp.builder() + .id("imp-1") + .ext(mapper.valueToTree(ExtPrebid.of(null, extImpBeop))) + .build(); + } + + private static BidderCall givenHttpCall(String body) { + return BidderCall.succeededHttp( + HttpRequest.builder().build(), + HttpResponse.of(200, null, body), + null); + } + + private static BidResponse givenBidResponse(Bid... bids) { + return BidResponse.builder() + .cur("USD") + .seatbid(List.of(SeatBid.builder() + .bid(List.of(bids)) + .build())) + .build(); + } +} diff --git a/src/test/java/org/prebid/server/it/BeopTest.java b/src/test/java/org/prebid/server/it/BeopTest.java new file mode 100644 index 00000000000..f2d0232ce88 --- /dev/null +++ b/src/test/java/org/prebid/server/it/BeopTest.java @@ -0,0 +1,32 @@ +package org.prebid.server.it; + +import io.restassured.response.Response; +import org.json.JSONException; +import org.junit.jupiter.api.Test; +import org.prebid.server.model.Endpoint; + +import java.io.IOException; + +import static com.github.tomakehurst.wiremock.client.WireMock.aResponse; +import static com.github.tomakehurst.wiremock.client.WireMock.equalToJson; +import static com.github.tomakehurst.wiremock.client.WireMock.post; +import static com.github.tomakehurst.wiremock.client.WireMock.urlPathEqualTo; +import static java.util.Collections.singletonList; + +public class BeopTest extends IntegrationTest { + + @Test + public void openrtb2AuctionShouldRespondWithBidsFromBeop() throws IOException, JSONException { + // given + WIRE_MOCK_RULE.stubFor(post(urlPathEqualTo("/beop-exchange")) + .withRequestBody(equalToJson(jsonFrom("openrtb2/beop/test-beop-bid-request.json"))) + .willReturn(aResponse().withBody(jsonFrom("openrtb2/beop/test-beop-bid-response.json")))); + + // when + final Response response = responseFor("openrtb2/beop/test-auction-beop-request.json", + Endpoint.openrtb2_auction); + + // then + assertJsonEquals("openrtb2/beop/test-auction-beop-response.json", response, singletonList("beop")); + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/beop/test-auction-beop-request.json b/src/test/resources/org/prebid/server/it/openrtb2/beop/test-auction-beop-request.json new file mode 100644 index 00000000000..eec1d9548aa --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/beop/test-auction-beop-request.json @@ -0,0 +1,23 @@ +{ + "id": "request_id", + "imp": [ + { + "id": "imp_id", + "banner": { + "w": 300, + "h": 250 + }, + "ext": { + "beop": { + "pid": "testPublisherId" + } + } + } + ], + "tmax": 5000, + "regs": { + "ext": { + "gdpr": 0 + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/beop/test-auction-beop-response.json b/src/test/resources/org/prebid/server/it/openrtb2/beop/test-auction-beop-response.json new file mode 100644 index 00000000000..455999aced3 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/beop/test-auction-beop-response.json @@ -0,0 +1,38 @@ +{ + "id": "request_id", + "seatbid": [ + { + "bid": [ + { + "id": "bid_id", + "impid": "imp_id", + "exp": 300, + "price": 3.33, + "crid": "creativeId", + "mtype": 1, + "ext": { + "origbidcpm": 3.33, + "prebid": { + "type": "banner", + "meta": { + "adaptercode": "beop" + } + } + } + } + ], + "seat": "beop", + "group": 0 + } + ], + "cur": "USD", + "ext": { + "responsetimemillis": { + "beop": "{{ beop.response_time_ms }}" + }, + "prebid": { + "auctiontimestamp": 0 + }, + "tmaxrequest": 5000 + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/beop/test-beop-bid-request.json b/src/test/resources/org/prebid/server/it/openrtb2/beop/test-beop-bid-request.json new file mode 100644 index 00000000000..ee6da17cd38 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/beop/test-beop-bid-request.json @@ -0,0 +1,52 @@ +{ + "id": "request_id", + "imp": [ + { + "id": "imp_id", + "banner": { + "w": 300, + "h": 250 + }, + "secure": 1, + "ext": { + "tid": "${json-unit.any-string}", + "bidder": { + "pid": "testPublisherId" + } + } + } + ], + "site": { + "domain": "www.example.com", + "page": "http://www.example.com", + "publisher": { + "domain": "example.com" + }, + "ext": { + "amp": 0 + } + }, + "device": { + "ua": "userAgent", + "ip": "193.168.244.1" + }, + "at": 1, + "tmax": "${json-unit.any-number}", + "cur": ["USD"], + "source" : { + "tid" : "${json-unit.any-string}" + }, + "regs": { + "gdpr": 0 + }, + "ext": { + "prebid": { + "server": { + "externalurl": "http://localhost:8080", + "gvlid": 1, + "datacenter": "local", + "endpoint": "/openrtb2/auction" + } + } + } +} diff --git a/src/test/resources/org/prebid/server/it/openrtb2/beop/test-beop-bid-response.json b/src/test/resources/org/prebid/server/it/openrtb2/beop/test-beop-bid-response.json new file mode 100644 index 00000000000..180173549d8 --- /dev/null +++ b/src/test/resources/org/prebid/server/it/openrtb2/beop/test-beop-bid-response.json @@ -0,0 +1,21 @@ +{ + "id": "request_id", + "seatbid": [ + { + "bid": [ + { + "id": "bid_id", + "impid": "imp_id", + "price": 3.33, + "crid": "creativeId", + "mtype": 1, + "ext": { + "prebid": { + "type": "banner" + } + } + } + ] + } + ] +} diff --git a/src/test/resources/org/prebid/server/it/test-application.properties b/src/test/resources/org/prebid/server/it/test-application.properties index 7d5724b2a69..da39a47f7e0 100644 --- a/src/test/resources/org/prebid/server/it/test-application.properties +++ b/src/test/resources/org/prebid/server/it/test-application.properties @@ -159,6 +159,8 @@ adapters.beintoo.enabled=true adapters.beintoo.endpoint=http://localhost:8090/beintoo-exchange adapters.bematterfull.enabled=true adapters.bematterfull.endpoint=http://localhost:8090/bematterfull-exchange?host={{Host}}&pid={{SourceId}} +adapters.beop.enabled=true +adapters.beop.endpoint=http://localhost:8090/beop-exchange adapters.bidscube.enabled=true adapters.bidscube.endpoint=http://localhost:8090/bidscube-exchange adapters.bidstack.enabled=true From 090d8c30d5a9af71119aabcc57b8bc591e153f06 Mon Sep 17 00:00:00 2001 From: pkaczmarek Date: Tue, 28 Apr 2026 14:50:48 +0200 Subject: [PATCH 2/3] fix comments --- .../org/prebid/server/bidder/beop/BeopBidder.java | 15 ++++----------- .../openrtb/ext/request/beop/ExtImpBeop.java | 10 ++++------ src/main/resources/bidder-config/beop.yaml | 3 --- src/main/resources/static/bidder-params/beop.json | 8 ++------ 4 files changed, 10 insertions(+), 26 deletions(-) diff --git a/src/main/java/org/prebid/server/bidder/beop/BeopBidder.java b/src/main/java/org/prebid/server/bidder/beop/BeopBidder.java index b0e88f6fc0d..975f6c02573 100644 --- a/src/main/java/org/prebid/server/bidder/beop/BeopBidder.java +++ b/src/main/java/org/prebid/server/bidder/beop/BeopBidder.java @@ -46,9 +46,6 @@ public BeopBidder(String endpointUrl, JacksonMapper mapper) { @Override public Result>> makeHttpRequests(BidRequest bidRequest) { final List imps = bidRequest.getImp(); - if (CollectionUtils.isEmpty(imps)) { - return Result.withError(BidderError.badInput("No impressions provided")); - } final ExtImpBeop extImpBeop; try { @@ -83,17 +80,17 @@ private String buildEndpointUrl(ExtImpBeop ext) { throw new PreBidException("Invalid endpoint URL: " + e.getMessage()); } - final String pid = StringUtils.trimToNull(ext.getBeopPublisherId()); + final String pid = StringUtils.trimToNull(ext.getPid()); if (StringUtils.isNotEmpty(pid)) { uriBuilder.addParameter("pid", pid); } - final String nid = StringUtils.trimToNull(ext.getBeopNetworkId()); + final String nid = StringUtils.trimToNull(ext.getNid()); if (StringUtils.isNotEmpty(nid)) { uriBuilder.addParameter("nid", nid); } - final String nptnid = StringUtils.trimToNull(ext.getBeopNetworkPartnerId()); + final String nptnid = StringUtils.trimToNull(ext.getNtpnid()); if (StringUtils.isNotEmpty(nptnid)) { uriBuilder.addParameter("nptnid", nptnid); } @@ -142,14 +139,10 @@ private static BidderBid makeBidderBid(Bid bid, String currency, List BidType.banner; case 2 -> BidType.video; - default -> throw new PreBidException( + case null, default -> throw new PreBidException( "Failed to parse bid mtype for impression \"%s\"".formatted(bid.getImpid())); }; } diff --git a/src/main/java/org/prebid/server/proto/openrtb/ext/request/beop/ExtImpBeop.java b/src/main/java/org/prebid/server/proto/openrtb/ext/request/beop/ExtImpBeop.java index 054e4cda6f8..e2e2cf76c88 100644 --- a/src/main/java/org/prebid/server/proto/openrtb/ext/request/beop/ExtImpBeop.java +++ b/src/main/java/org/prebid/server/proto/openrtb/ext/request/beop/ExtImpBeop.java @@ -1,6 +1,5 @@ package org.prebid.server.proto.openrtb.ext.request.beop; -import com.fasterxml.jackson.annotation.JsonAlias; import com.fasterxml.jackson.annotation.JsonProperty; import lombok.Value; @@ -8,12 +7,11 @@ public class ExtImpBeop { @JsonProperty("pid") - String beopPublisherId; + String pid; @JsonProperty("nid") - String beopNetworkId; + String nid; - @JsonProperty("nptnid") - @JsonAlias("ntpnid") - String beopNetworkPartnerId; + @JsonProperty("ntpnid") + String ntpnid; } diff --git a/src/main/resources/bidder-config/beop.yaml b/src/main/resources/bidder-config/beop.yaml index 916f0f4a87d..c71eac10157 100644 --- a/src/main/resources/bidder-config/beop.yaml +++ b/src/main/resources/bidder-config/beop.yaml @@ -7,9 +7,6 @@ adapters: - USA meta-info: maintainer-email: "tech@collectiveaudience.co" - app-media-types: - - banner - - video site-media-types: - banner - video diff --git a/src/main/resources/static/bidder-params/beop.json b/src/main/resources/static/bidder-params/beop.json index 5f5bf8db4bf..8b34ac91f70 100644 --- a/src/main/resources/static/bidder-params/beop.json +++ b/src/main/resources/static/bidder-params/beop.json @@ -12,13 +12,9 @@ "type": "string", "description": "Beop Network ID" }, - "nptnid": { - "type": "string", - "description": "Network partner ID" - }, "ntpnid": { "type": "string", - "description": "Legacy alias for network partner ID; use nptnid" + "description": "Network partner ID" } }, "oneOf": [ @@ -30,7 +26,7 @@ { "required": [ "nid", - "nptnid" + "ntpnid" ] } ] From 9801715029e5550888dfd5dfab40802d38b7251b Mon Sep 17 00:00:00 2001 From: pkaczmarek Date: Tue, 28 Apr 2026 14:57:46 +0200 Subject: [PATCH 3/3] fix comments --- .../prebid/server/bidder/beop/BeopBidderTest.java | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/src/test/java/org/prebid/server/bidder/beop/BeopBidderTest.java b/src/test/java/org/prebid/server/bidder/beop/BeopBidderTest.java index 0bdac5576c6..f19231fab3f 100644 --- a/src/test/java/org/prebid/server/bidder/beop/BeopBidderTest.java +++ b/src/test/java/org/prebid/server/bidder/beop/BeopBidderTest.java @@ -35,19 +35,6 @@ public void creationShouldFailOnInvalidEndpointUrl() { assertThatIllegalArgumentException().isThrownBy(() -> new BeopBidder("invalid_url", jacksonMapper)); } - @Test - public void makeHttpRequestsShouldReturnErrorWhenRequestHasNoImps() { - // given - final BidRequest bidRequest = BidRequest.builder().build(); - - // when - final Result>> result = target.makeHttpRequests(bidRequest); - - // then - assertThat(result.getValue()).isEmpty(); - assertThat(result.getErrors()).containsExactly(BidderError.badInput("No impressions provided")); - } - @Test public void makeHttpRequestsShouldReturnErrorWhenImpExtCouldNotBeParsed() { // given