Skip to content

config.h: Add missing MLK_CONFIG_NO_ASM_VALUE_BARRIER #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkannwischer merged 1 commit into from
Dec 3, 2025
Merged

config.h: Add missing MLK_CONFIG_NO_ASM_VALUE_BARRIER #1325

mkannwischer merged 1 commit into from
Dec 3, 2025

Conversation

@willieyz
Copy link
Contributor

@willieyz willieyz commented Nov 28, 2025 •
edited
Loading

@willieyz willieyz mentioned this pull request Nov 28, 2025
Merged
@willieyz willieyz marked this pull request as ready for review December 1, 2025 02:50
@willieyz willieyz requested a review from a team as a code owner December 1, 2025 02:50
mkannwischer
mkannwischer requested changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willieyz for adding MLK_CONFIG_NO_ASM_VALUE_BARRIER. Almost good.

@willieyz
config.h: Add missing MLK_CONFIG_NO_ASM_VALUE_BARRIER
b277e7b 
- This commit add missing MLK_CONFIG_NO_ASM_VALUE_BARRIER
  and remove following from autogen:
  "MLK_CONFIG_NO_ASM_VALUE_BARRIER", # TODO: Add to config?

- Also, this commit added the missing citation for FIPS203 in config.h

Signed-off-by: willieyz <willie.zhao@chelpis.com>
mkannwischer
mkannwischer approved these changes Dec 3, 2025
View reviewed changes
Copy link
Contributor

@mkannwischer mkannwischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @willieyz!

@mkannwischer mkannwischer merged commit 49caebb into main Dec 3, 2025
387 checks passed
@mkannwischer mkannwischer deleted the align-config branch December 3, 2025 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkannwischer mkannwischer mkannwischer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@willieyz @mkannwischer