Better test logs

Author: simolus3

packages/common/src/client/ConnectionManager.ts

@@ -355,7 +355,7 @@ class ActiveSubscription {
 }
 
 class SyncStreamSubscriptionHandle implements SyncStreamSubscription {
-  private active: boolean = false;
+  private active: boolean = true;
 
   constructor(readonly subscription: ActiveSubscription) {
     subscription.refcount++;

packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts

@@ -1,7 +1,6 @@
 import Logger, { ILogger } from 'js-logger';
 
-import { FULL_SYNC_PRIORITY, InternalProgressInformation } from '../../../db/crud/SyncProgress.js';
-import * as sync_status from '../../../db/crud/SyncStatus.js';
+import { InternalProgressInformation } from '../../../db/crud/SyncProgress.js';
 import { SyncStatus, SyncStatusOptions } from '../../../db/crud/SyncStatus.js';
 import { AbortOperation } from '../../../utils/AbortOperation.js';
 import { BaseListener, BaseObserver, BaseObserverInterface, Disposable } from '../../../utils/BaseObserver.js';
@@ -1017,6 +1016,14 @@ The next upload iteration will be delayed.`);
 
     async function control(op: PowerSyncControlCommand, payload?: Uint8Array | string) {
       const rawResponse = await adapter.control(op, payload ?? null);
+      const logger = syncImplementation.logger;
+      logger.trace(
+        'powersync_control',
+        op,
+        payload == null || typeof payload == 'string' ? payload : '<bytes>',
+        rawResponse
+      );
+
       await handleInstructions(JSON.parse(rawResponse));
     }
 

packages/node/tests/sync-stream.test.ts

@@ -1,4 +1,4 @@
-import { describe, vi, expect } from 'vitest';
+import { describe, vi, expect, onTestFinished } from 'vitest';
 import { PowerSyncConnectionOptions, SyncClientImplementation, SyncStreamConnectionMethod } from '@powersync/common';
 import Logger from 'js-logger';
 import { bucket, checkpoint, mockSyncServiceTest, nextStatus, stream, TestConnector } from './utils';
@@ -30,6 +30,10 @@ describe('Sync streams', () => {
     const database = await syncService.createDatabase();
     const a = await database.syncStream('stream', { foo: 'a' }).subscribe();
     const b = await database.syncStream('stream', { foo: 'b' }).subscribe({ priority: 1 });
+    onTestFinished(() => {
+      a.unsubscribe();
+      b.unsubscribe();
+    });
 
     await database.connect(new TestConnector(), defaultOptions);
 

packages/node/tests/sync.test.ts

@@ -15,8 +15,6 @@ import {
 } from '@powersync/common';
 import Logger from 'js-logger';
 
-Logger.useDefaults({ defaultLevel: Logger.WARN });
-
 describe('Sync', () => {
   describe('js client', () => {
     defineSyncTests(SyncClientImplementation.JAVASCRIPT);

packages/node/tests/utils.ts

@@ -14,11 +14,12 @@ import {
   PowerSyncDatabase,
   Schema,
   StreamingSyncCheckpoint,
-  StreamingSyncCheckpointComplete,
   StreamingSyncLine,
   SyncStatus,
   Table
 } from '../lib';
+import { createLogger } from '@powersync/common';
+import Logger from 'js-logger';
 
 export async function createTempDir() {
   const ostmpdir = os.tmpdir();
@@ -57,12 +58,18 @@ export async function createDatabase(
   tmpdir: string,
   options: Partial<NodePowerSyncDatabaseOptions> = {}
 ): Promise<PowerSyncDatabase> {
+  const defaultLogger = createLogger('PowerSyncTest', { logLevel: Logger.TRACE });
+  (defaultLogger as any).invoke = (_, args) => {
+    console.log(...args);
+  };
+
   const database = new PowerSyncDatabase({
     schema: AppSchema,
     database: {
       dbFilename: 'test.db',
       dbLocation: tmpdir
     },
+    logger: defaultLogger,
     ...options
   });
   await database.init();

packages/node/vitest.config.ts

@@ -1,4 +1,8 @@
 import { defineConfig } from 'vitest/config';
 
 // We need to define an empty config to be part of the vitest works
-export default defineConfig({});
+export default defineConfig({
+  test: {
+    silent: false
+  }
+});