Fix feature detection for finalization registry

simolus3 · simolus3 · commit 8b8aa7ae7c2a · 2025-09-09T15:11:51.000+02:00
diff --git a/packages/common/src/client/ConnectionManager.ts b/packages/common/src/client/ConnectionManager.ts
@@ -384,7 +384,7 @@ class SyncStreamSubscriptionHandle implements SyncStreamSubscription {
 }
 
 const _finalizer =
-  FinalizationRegistry != null
+  'FinalizationRegistry' in globalThis
     ? new FinalizationRegistry<ActiveSubscription>((sub) => {
         sub.logger.warn(
           `A subscription to ${sub.name} with params ${JSON.stringify(sub.parameters)} leaked! Please ensure calling unsubscribe() when you don't need a subscription anymore. For global subscriptions, consider storing them in global fields to avoid this warning.`

Original file line number	Diff line number	Diff line change
`@@ -384,7 +384,7 @@ class SyncStreamSubscriptionHandle implements SyncStreamSubscription {`
`384`	`384`	`}`
`385`	`385`
`386`	`386`	`const _finalizer =`
`387`		`- FinalizationRegistry != null`
	`387`	`+ 'FinalizationRegistry' in globalThis`
`388`	`388`	`? new FinalizationRegistry<ActiveSubscription>((sub) => {`
`389`	`389`	`sub.logger.warn(`
`390`	`390`	`A subscription to ${sub.name} with params ${JSON.stringify(sub.parameters)} leaked! Please ensure calling unsubscribe() when you don't need a subscription anymore. For global subscriptions, consider storing them in global fields to avoid this warning.`