Review feedback

Author: simolus3

packages/common/src/client/sync/bucket/BucketStorageAdapter.ts

@@ -50,6 +50,11 @@ export interface BucketChecksum {
    * Count of operations - informational only.
    */
   count?: number;
+  /**
+   * The JavaScript client does not use this field, which is why it's defined to be `any`. We rely on the structure of
+   * this interface to pass custom `BucketChecksum`s to the Rust client in unit tests, which so all fields need to be
+   * present.
+   */
   subscriptions?: any;
 }
 

packages/common/src/client/sync/stream/core-instruction.ts

@@ -86,6 +86,8 @@ export function coreStatusToJs(status: CoreSyncStatus): sync_status.SyncStatusOp
     connected: status.connected,
     connecting: status.connecting,
     dataFlow: {
+      // We expose downloading as a boolean field, the core extension reports download information as a nullable
+      // download status. When that status is non-null, a download is in progress.
       downloading: status.downloading != null,
       downloadProgress: status.downloading?.buckets,
       internalStreamSubscriptions: status.streams