Review feedback

Author: simolus3

.changeset/light-clocks-hang.md

@@ -1,5 +1,8 @@
 ---
 '@powersync/common': patch
+'@powersync/node': patch
+'@powersync/web': patch
+'@powersync/react-native': patch
 ---
 
 Rust client: Properly upload CRUD entries made while offline.

packages/common/src/client/sync/stream/AbstractStreamingSyncImplementation.ts

@@ -999,7 +999,6 @@ The next upload iteration will be delayed.`);
       );
 
       this.notifyCompletedUploads = () => {
-        console.log('notify completed');
         controlInvocations?.enqueueData({ command: PowerSyncControlCommand.NOTIFY_CRUD_UPLOAD_COMPLETED });
       };
       await receivingLines;

packages/common/src/utils/DataStream.ts

@@ -39,7 +39,7 @@ export class DataStream<Data extends any = any> extends BaseObserver<DataStreamL
   protected isClosed: boolean;
 
   protected processingPromise: Promise<void> | null;
-  protected notifyDataAdded: ((_: null) => void) | null;
+  protected notifyDataAdded: (() => void) | null;
 
   protected logger: ILogger;
 
@@ -91,7 +91,7 @@ export class DataStream<Data extends any = any> extends BaseObserver<DataStreamL
     }
 
     this.dataQueue.push(data);
-    this.notifyDataAdded?.(null);
+    this.notifyDataAdded?.();
 
     this.processQueue();
   }
@@ -194,7 +194,7 @@ export class DataStream<Data extends any = any> extends BaseObserver<DataStreamL
     }
 
     if (this.dataQueue.length <= this.lowWatermark) {
-      const dataAdded = new Promise((resolve) => {
+      const dataAdded = new Promise<void>((resolve) => {
         this.notifyDataAdded = resolve;
       });