make node tests more stable

Author: stevensJourney

packages/node/tests/sync.test.ts

@@ -1,7 +1,6 @@
-import { describe, vi, expect, beforeEach } from 'vitest';
 import util from 'node:util';
+import { beforeEach, describe, expect, vi } from 'vitest';
 
-import { bucket, MockSyncService, mockSyncServiceTest, TestConnector, waitForSyncStatus } from './utils';
 import {
   AbstractPowerSyncDatabase,
   BucketChecksum,
@@ -14,6 +13,7 @@ import {
   SyncStreamConnectionMethod
 } from '@powersync/common';
 import Logger from 'js-logger';
+import { bucket, MockSyncService, mockSyncServiceTest, TestConnector, waitForSyncStatus } from './utils';
 
 describe('Sync', () => {
   describe('js client', () => {
@@ -821,10 +821,11 @@ function defineSyncTests(impl: SyncClientImplementation) {
       const powersync = await syncService.createDatabase({ schema: customSchema, logger });
       powersync.connect(new TestConnector(), options);
 
-      await vi.waitFor(() => expect(syncService.connectedListeners).toHaveLength(1));
-      expect(logMessages).toEqual(
-        expect.arrayContaining([expect.stringContaining('Raw tables require the Rust-based sync client')])
-      );
+      await vi.waitFor(() => {
+        expect(logMessages).toEqual(
+          expect.arrayContaining([expect.stringContaining('Raw tables require the Rust-based sync client')])
+        );
+      });
     });
 
     mockSyncServiceTest(`does not warn about raw tables if they're not used`, async ({ syncService }) => {

packages/node/tests/utils.ts

@@ -9,17 +9,16 @@ import { onTestFinished, test } from 'vitest';
 import {
   AbstractPowerSyncDatabase,
   BucketChecksum,
-  column,
   NodePowerSyncDatabaseOptions,
   PowerSyncBackendConnector,
   PowerSyncCredentials,
   PowerSyncDatabase,
-  PowerSyncDatabaseOptions,
   Schema,
   StreamingSyncCheckpoint,
   StreamingSyncLine,
   SyncStatus,
-  Table
+  Table,
+  column
 } from '../lib';
 
 export async function createTempDir() {
@@ -67,7 +66,7 @@ export async function createDatabase(
   const database = new PowerSyncDatabase({
     schema: AppSchema,
     ...options,
-    logger: defaultLogger,
+    logger: options.logger ?? defaultLogger,
     database: {
       dbFilename: 'test.db',
       dbLocation: tmpdir,
@@ -103,6 +102,9 @@ export const mockSyncServiceTest = tempDirectoryTest.extend<{
       stream: ReadableStreamDefaultController<StreamingSyncLine>;
     }
 
+    // Uses a unique database name per mockSyncServiceTest to avoid conflicts with other tests.
+    const databaseName = `test-${crypto.randomUUID()}.db`;
+
     const listeners: Listener[] = [];
 
     const inMemoryFetch: typeof fetch = async (info, init?) => {
@@ -149,6 +151,10 @@ export const mockSyncServiceTest = tempDirectoryTest.extend<{
     const newConnection = async (options?: Partial<NodePowerSyncDatabaseOptions>) => {
       const db = await createDatabase(tmpdir, {
         ...options,
+        database: {
+          dbFilename: databaseName,
+          ...options?.database
+        },
         remoteOptions: {
           fetchImplementation: inMemoryFetch
         }