Code cleanup

Author: stevensJourney

packages/web/src/db/adapters/AsyncDatabaseConnection.ts

@@ -25,7 +25,15 @@ export type OnTableChangeCallback = (event: BatchedUpdateNotification) => void;
 export interface AsyncDatabaseConnection<Config extends ResolvedWebSQLOpenOptions = ResolvedWebSQLOpenOptions> {
   init(): Promise<void>;
   close(): Promise<void>;
+  /**
+   * Marks the connection as in-use by a certain actor.
+   * @returns A hold ID which can be used to release the hold.
+   */
   markHold(): Promise<string>;
+  /**
+   * Releases a hold on the connection.
+   * @param holdId The hold ID to release.
+   */
   releaseHold(holdId: string): Promise<void>;
   execute(sql: string, params?: any[]): Promise<ProxiedQueryResult>;
   executeRaw(sql: string, params?: any[]): Promise<any[][]>;

packages/web/src/worker/db/SharedWASQLiteConnection.ts

@@ -80,12 +80,11 @@ export class SharedWASQLiteConnection implements AsyncDatabaseConnection {
     clientIds.delete(clientId);
 
     if (this.activeHoldId) {
-      /**
-       * The hold hasn't been released, but we're closing now.
-       * We can proactively cleanup and release the hold.
-       */
-      await this.connection.execute('ROLLBACK').catch(() => {});
-      await this.connection.releaseHold(this.activeHoldId).catch(() => {});
+      // We can't cleanup here since we're not in a lock context.
+      // The cleanup will occur once a new hold is acquired.
+      this.logger.info(
+        `Hold ${this.activeHoldId} was still active when the connection was closed. Cleanup will occur once a new hold is acquired.`
+      );
     }
 
     if (clientIds.size == 0) {