Node: Create dbLocation if it doesn't exist.

Author: simolus3

.changeset/lazy-moons-prove.md

@@ -0,0 +1,5 @@
+---
+'@powersync/node': patch
+---
+
+Fix compilation errors on Windows.

.changeset/nice-steaks-approve.md

@@ -0,0 +1,5 @@
+---
+'@powersync/node': patch
+---
+
+Create `dbLocation` directory if it doesn't exist.

packages/node/package.json

@@ -46,7 +46,7 @@
     "@powersync/common": "workspace:^1.22.0"
   },
   "dependencies": {
-    "@powersync/better-sqlite3": "^0.1.0",
+    "@powersync/better-sqlite3": "^0.1.1",
     "@powersync/common": "workspace:*",
     "async-lock": "^1.4.0",
     "bson": "^6.6.0",

packages/node/src/db/BetterSQLite3DBAdapter.ts

@@ -1,3 +1,4 @@
+import fs from 'node:fs/promises';
 import * as path from 'node:path';
 import { Worker } from 'node:worker_threads';
 import * as Comlink from 'comlink';
@@ -53,6 +54,10 @@ export class BetterSQLite3DBAdapter extends BaseObserver<DBAdapterListener> impl
   async initialize() {
     let dbFilePath = this.options.dbFilename;
     if (this.options.dbLocation !== undefined) {
+      // SQLite reports a misuse error when the target directory of the database doesn't exist,
+      // so create it now before we access the database.
+      await fs.mkdir(this.options.dbLocation, { recursive: true });
+
       dbFilePath = path.join(this.options.dbLocation, dbFilePath);
     }
 

packages/node/tests/PowerSyncDatabase.test.ts

@@ -1,8 +1,8 @@
+import * as path from 'node:path';
 import { Worker } from 'node:worker_threads';
-import fs from 'node:fs/promises';
 
-import { vi, expect, test, onTestFinished } from 'vitest';
-import { AppSchema, createTempDir, databaseTest } from './utils';
+import { vi, expect, test } from 'vitest';
+import { AppSchema, databaseTest, tempDirectoryTest } from './utils';
 import { PowerSyncDatabase } from '../lib';
 import { WorkerOpener } from '../lib/db/options';
 
@@ -19,8 +19,7 @@ test('validates options', async () => {
   }).rejects.toThrowError('Needs at least one worker for reads');
 });
 
-test('can customize loading workers', async () => {
-  const directory = await createTempDir();
+tempDirectoryTest('can customize loading workers', async ({tmpdir}) => {
   const defaultWorker: WorkerOpener = (...args) => new Worker(...args);
 
   const openFunction = vi.fn(defaultWorker); // Wrap in vi.fn to count invocations
@@ -29,7 +28,7 @@ test('can customize loading workers', async () => {
     schema: AppSchema,
     database: {
       dbFilename: 'test.db',
-      dbLocation: directory,
+      dbLocation: tmpdir,
       openWorker: openFunction,
       readWorkerCount: 2
     }
@@ -38,8 +37,6 @@ test('can customize loading workers', async () => {
   await database.get('SELECT 1;'); // Make sure the database is ready and works
   expect(openFunction).toHaveBeenCalledTimes(3); // One writer, two readers
   await database.close();
-
-  onTestFinished(async () => fs.rm(directory, { recursive: true }));
 });
 
 databaseTest('links powersync', async ({ database }) => {
@@ -95,6 +92,19 @@ databaseTest('can watch tables', async ({ database }) => {
   await expect.poll(() => fn).toHaveBeenCalledTimes(2);
 });
 
+tempDirectoryTest('automatically creates directory', async ({tmpdir}) => {
+  const database = new PowerSyncDatabase({
+    schema: AppSchema,
+    database: {
+      dbFilename: 'test.db',
+      dbLocation: path.join(tmpdir, 'some', 'nested', 'location', 'that', 'does', 'not', 'exist'),
+      readWorkerCount: 2
+    }
+  });
+
+  await database.get('SELECT 1;'); // Make sure the database is ready and works
+});
+
 databaseTest.skip('can watch queries', async ({ database }) => {
   const query = await database.watch('SELECT * FROM todos;', [])[Symbol.asyncIterator]();
   expect((await query.next()).value.rows).toHaveLength(0);

packages/node/tests/utils.ts

@@ -23,17 +23,23 @@ export const AppSchema = new Schema({
 
 export type Database = (typeof AppSchema)['types'];
 
-export const databaseTest = test.extend<{ database: PowerSyncDatabase }>({
-  database: async ({}, use) => {
+export const tempDirectoryTest = test.extend<{ tmpdir: string }>({
+  tmpdir: async ({}, use) => {
     const directory = await createTempDir();
+    await use(directory);
+    await fs.rm(directory, { recursive: true });
+  },
+});
+
+export const databaseTest = tempDirectoryTest.extend<{ database: PowerSyncDatabase }>({
+  database: async ({tmpdir}, use) => {
     const database = new PowerSyncDatabase({
       schema: AppSchema,
       database: {
         dbFilename: 'test.db',
-        dbLocation: directory
+        dbLocation: tmpdir
       }
     });
     await use(database);
-    await fs.rm(directory, { recursive: true });
   }
 });