Skip to content
This repository was archived by the owner on Mar 11, 2019. It is now read-only.

Commit 6e4b879

Browse files
committed
fix(#56): fix an issue
Closes #56
1 parent 1b732f8 commit 6e4b879

File tree

7 files changed

+20
-15
lines changed

7 files changed

+20
-15
lines changed

powerapi-core/src/main/scala/org/powerapi/PowerMeter.scala

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,8 @@
2222
*/
2323
package org.powerapi
2424

25+
import java.util.UUID
26+
2527
import akka.actor.{ ActorRef, ActorRefFactory, ActorSystem, Props }
2628
import akka.event.LoggingReceive
2729
import akka.pattern.{ ask, after, gracefulStop }
@@ -239,5 +241,5 @@ trait PowerDisplay {
239241
/**
240242
* Displays data from power reports.
241243
*/
242-
def display(timestamp: Long, targets: Set[Target], devices: Set[String], power: Power): Unit
244+
def display(muid: UUID, timestamp: Long, targets: Set[Target], devices: Set[String], power: Power)
243245
}

powerapi-core/src/main/scala/org/powerapi/reporter/ConsoleDisplay.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
*/
2323
package org.powerapi.reporter
2424

25+
import java.util.UUID
2526
import org.powerapi.PowerDisplay
2627
import org.powerapi.core.power.Power
2728
import org.powerapi.core.target.Target
@@ -34,8 +35,8 @@ import org.powerapi.core.target.Target
3435
*/
3536
class ConsoleDisplay extends PowerDisplay {
3637

37-
def display(timestamp: Long, targets: Set[Target], devices: Set[String], power: Power) {
38-
println(s"timestamp=$timestamp;target=${targets.mkString(";")};devices=${devices.mkString(",")};power=${power.toWatts}")
38+
def display(muid: UUID, timestamp: Long, targets: Set[Target], devices: Set[String], power: Power) {
39+
println(s"muid=$muid;timestamp=$timestamp;target=${targets.mkString(";")};devices=${devices.mkString(",")};power=${power.toWatts}")
3940
}
4041
}
4142

powerapi-core/src/main/scala/org/powerapi/reporter/FileDisplay.scala

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
*/
2323
package org.powerapi.reporter
2424

25+
import java.util.UUID
2526
import org.powerapi.PowerDisplay
2627
import org.powerapi.core.power.Power
2728
import org.powerapi.core.target.Target
@@ -37,7 +38,7 @@ class FileDisplay(filepath: String) extends PowerDisplay {
3738

3839
lazy val output = Resource.fromFile(filepath)
3940

40-
def display(timestamp: Long, targets: Set[Target], devices: Set[String], power: Power) {
41-
output.append(s"timestamp=$timestamp;targets=${targets.mkString(",")};devices=${devices.mkString(",")};power=${power.toWatts}\n")
41+
def display(muid: UUID, timestamp: Long, targets: Set[Target], devices: Set[String], power: Power) {
42+
output.append(s"muid=$muid;timestamp=$timestamp;targets=${targets.mkString(",")};devices=${devices.mkString(",")};power=${power.toWatts}\n")
4243
}
4344
}

powerapi-core/src/main/scala/org/powerapi/reporter/JFreeChartDisplay.scala

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
*/
2323
package org.powerapi.reporter
2424

25+
import java.util.UUID
2526
import javax.swing.SwingUtilities
2627
import org.powerapi.PowerDisplay
2728
import org.powerapi.core.power.Power
@@ -43,7 +44,7 @@ class JFreeChartDisplay extends PowerDisplay {
4344
}
4445
})
4546

46-
def display(timestamp: Long, targets: Set[Target], devices: Set[String], power: Power) {
47+
def display(muid: UUID, timestamp: Long, targets: Set[Target], devices: Set[String], power: Power) {
4748
Chart.process(Map(s"${targets.mkString(",")}" -> power.toWatts), timestamp)
4849
}
4950
}

powerapi-core/src/main/scala/org/powerapi/reporter/ReporterComponent.scala

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,6 @@ class ReporterComponent(output: PowerDisplay) extends APIComponent {
3939
} orElse default
4040

4141
def report(aggPowerReport: AggregatePowerReport): Unit = {
42-
output.display(aggPowerReport.tick.timestamp, aggPowerReport.targets, aggPowerReport.devices, aggPowerReport.power)
42+
output.display(aggPowerReport.muid, aggPowerReport.tick.timestamp, aggPowerReport.targets, aggPowerReport.devices, aggPowerReport.power)
4343
}
4444
}

powerapi-core/src/test/scala/org/powerapi/reporter/ConsoleDisplaySuite.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,8 @@ import org.powerapi.module.PowerChannel.{ AggregatePowerReport, RawPowerReport,
3636
import scala.concurrent.duration.DurationInt
3737

3838
class ConsoleDisplayMock(testActor: ActorRef) extends ConsoleDisplay {
39-
override def display(timestamp: Long, targets: Set[Target], devices: Set[String], power: Power) {
40-
testActor ! s"timestamp=$timestamp;targets=${targets.mkString(",")};devices=${devices.mkString(",")};power=${power.toWatts}"
39+
override def display(muid: UUID, timestamp: Long, targets: Set[Target], devices: Set[String], power: Power) {
40+
testActor ! s"muid=$muid;timestamp=$timestamp;targets=${targets.mkString(",")};devices=${devices.mkString(",")};power=${power.toWatts}"
4141
}
4242
}
4343

@@ -76,9 +76,9 @@ class ConsoleDisplaySuite(system: ActorSystem) extends UnitTest(system) {
7676
render(aggR2)(eventBus)
7777
render(aggR3)(eventBus)
7878

79-
expectMsgClass(classOf[String]) should equal(s"timestamp=${tickMock.timestamp};targets=1;devices=$device;power=${3.W.toWatts}")
80-
expectMsgClass(classOf[String]) should equal(s"timestamp=${tickMock.timestamp};targets=2;devices=$device;power=${1.W.toWatts}")
81-
expectMsgClass(classOf[String]) should equal(s"timestamp=${tickMock.timestamp};targets=3,4;devices=$device;power=${6.W.toWatts}")
79+
expectMsgClass(classOf[String]) should equal(s"muid=$muid;timestamp=${tickMock.timestamp};targets=1;devices=$device;power=${3.W.toWatts}")
80+
expectMsgClass(classOf[String]) should equal(s"muid=$muid;timestamp=${tickMock.timestamp};targets=2;devices=$device;power=${1.W.toWatts}")
81+
expectMsgClass(classOf[String]) should equal(s"muid=$muid;timestamp=${tickMock.timestamp};targets=3,4;devices=$device;power=${6.W.toWatts}")
8282
}
8383
}
8484

powerapi-core/src/test/scala/org/powerapi/reporter/FileDisplaySuite.scala

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,9 @@ class FileDisplaySuite(system: ActorSystem) extends UnitTest(system) {
7474
testFile.size.get should be > 0L
7575
testFile.lines() should (
7676
have size 3 and
77-
contain(s"timestamp=${tickMock.timestamp};targets=1;devices=$device;power=${3.W.toWatts}") and
78-
contain(s"timestamp=${tickMock.timestamp};targets=2;devices=$device;power=${1.W.toWatts}") and
79-
contain(s"timestamp=${tickMock.timestamp};targets=3,4;devices=$device;power=${6.W.toWatts}")
77+
contain(s"muid=$muid;timestamp=${tickMock.timestamp};targets=1;devices=$device;power=${3.W.toWatts}") and
78+
contain(s"muid=$muid;timestamp=${tickMock.timestamp};targets=2;devices=$device;power=${1.W.toWatts}") and
79+
contain(s"muid=$muid;timestamp=${tickMock.timestamp};targets=3,4;devices=$device;power=${6.W.toWatts}")
8080
)
8181
testFile.delete(true)
8282
}

0 commit comments

Comments
 (0)