Skip to content

Commit dd2f052

Browse files
authored
e2e: remove nightly tag code (#10863)
### Summary I guess the @:nightly-only tag has been deprecated... removing its remains. ### QA Notes n/a
1 parent 7b00abb commit dd2f052

File tree

5 files changed

+10
-18
lines changed

5 files changed

+10
-18
lines changed

.github/workflows/test-pull-request.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ jobs:
9191
report_currents: false
9292
install_undetectable_interpreters: false
9393
install_license: false
94-
skip_tags: "@:nightly-only"
9594
upload_logs: false
9695
allow_soft_fail: false
9796
secrets: inherit
@@ -109,7 +108,6 @@ jobs:
109108
report_currents: false
110109
install_undetectable_interpreters: false
111110
install_license: true
112-
skip_tags: "@:nightly-only"
113111
upload_logs: false
114112
allow_soft_fail: false
115113
secrets: inherit

test/e2e/infra/test-runner/test-tags.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -74,9 +74,6 @@ export enum TestTags {
7474
WORKBENCH = '@:workbench',
7575
REMOTE_SSH = '@:remote-ssh',
7676

77-
// exclude tags
78-
NIGHTLY_ONLY = '@:nightly-only',
79-
8077
// soft fail tag for tests that shouldn't fail merge to main
8178
SOFT_FAIL = '@:soft-fail'
8279
}

test/e2e/tests/interpreters/default-python-interpreter.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ test.use({
1313

1414
// electron only for now - windows doesn't have hidden interpreters and for web the deletePositronHistoryFiles is not valid
1515
test.describe('Default Interpreters - Python', {
16-
tag: [tags.INTERPRETER, tags.NIGHTLY_ONLY]
16+
tag: [tags.INTERPRETER]
1717
}, () => {
1818

1919
test.beforeAll(async function ({ settings }) {

test/e2e/tests/interpreters/default-r-interpreter.test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ test.use({
1313

1414
// electron only for now - windows doesn't have hidden interpreters and for web the deletePositronHistoryFiles is not valid
1515
test.describe('Default Interpreters - R', {
16-
tag: [tags.INTERPRETER, tags.NIGHTLY_ONLY, tags.ARK]
16+
tag: [tags.INTERPRETER, tags.ARK]
1717
}, () => {
1818

1919
test.beforeAll(async function ({ settings }) {

test/e2e/tests/interpreters/includes-excludes.test.ts

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,7 @@ test.describe('Interpreter: Includes', {
2424
}, { reload: true });
2525
});
2626

27-
test('Python - Can Include an Interpreter', {
28-
tag: [tags.NIGHTLY_ONLY]
29-
}, async function ({ sessions }) {
27+
test('Python - Can Include an Interpreter', async function ({ sessions }) {
3028

3129
const hiddenPython = process.env.POSITRON_HIDDEN_PY;
3230

@@ -35,16 +33,15 @@ test.describe('Interpreter: Includes', {
3533
: fail('Hidden Python version not set');
3634
});
3735

38-
test('R - Can Include an Interpreter', {
39-
tag: [tags.NIGHTLY_ONLY, tags.ARK]
40-
}, async function ({ sessions }) {
36+
test('R - Can Include an Interpreter',
37+
{ tag: [tags.ARK] }, async function ({ sessions }) {
4138

42-
const hiddenR = process.env.POSITRON_HIDDEN_R;
39+
const hiddenR = process.env.POSITRON_HIDDEN_R;
4340

44-
hiddenR
45-
? await sessions.start('rHidden')
46-
: fail('Hidden R version not set');
47-
});
41+
hiddenR
42+
? await sessions.start('rHidden')
43+
: fail('Hidden R version not set');
44+
});
4845
});
4946

5047
test.describe('Interpreter: Excludes', {

0 commit comments

Comments
 (0)