fix(x-randomvalues): prioritize native RN modules over polyfilled crypto #2013
+9
−5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In React Native environments,
getRandomValues()was incorrectly using the browser implementation instead of native modules (RNGetRandomValuesorExpoRandom), even when these native modules were installed and available.Ref - polkadot-js/wasm#598
Root Cause
The detection logic in
src/react-native.tschecked for the presence ofxglobal.cryptofirst. When libraries likereact-native-get-random-valuespolyfill the globalcryptoobject, this check would pass and use the browser implementation, never checking if native modules were available for React Native.Solution
Inverted the priority order of checks:
Before:
xglobal.cryptoexists -> use browser implementationAfter:
RNGetRandomValuesorExpoRandom) -> use native implementationxglobal.cryptoif available -> use browser implementation