From cf19476f4c876662a8205a5756c5b63357971663 Mon Sep 17 00:00:00 2001 From: Cameron DeCoster Date: Fri, 10 Apr 2026 13:02:51 -0600 Subject: [PATCH 1/2] fix: Add `displayNotifier` to Graph config --- .../dash-core-components/src/components/Graph.react.js | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/components/dash-core-components/src/components/Graph.react.js b/components/dash-core-components/src/components/Graph.react.js index 770c9defd6..94dab4559c 100644 --- a/components/dash-core-components/src/components/Graph.react.js +++ b/components/dash-core-components/src/components/Graph.react.js @@ -550,6 +550,11 @@ PlotlyGraph.propTypes = { * plot rather than registering them globally. */ locales: PropTypes.object, + + /** + * Determines whether or not notifier is displayed + */ + displayNotifier: PropTypes.bool, }), /** From 982e2382319fdfc264ba3bee4dd0256298c69a25 Mon Sep 17 00:00:00 2001 From: Cameron DeCoster Date: Fri, 10 Apr 2026 13:42:44 -0600 Subject: [PATCH 2/2] Remove schema/config comparison test --- .../integration/tab/test_tabs_with_graphs.py | 41 ------------------- 1 file changed, 41 deletions(-) diff --git a/components/dash-core-components/tests/integration/tab/test_tabs_with_graphs.py b/components/dash-core-components/tests/integration/tab/test_tabs_with_graphs.py index 7b98de6d39..b7525f00f9 100644 --- a/components/dash-core-components/tests/integration/tab/test_tabs_with_graphs.py +++ b/components/dash-core-components/tests/integration/tab/test_tabs_with_graphs.py @@ -1,7 +1,5 @@ from dash import Dash, Input, Output, dcc, html from dash.exceptions import PreventUpdate -import json -import os import pytest from selenium.webdriver.common.by import By from selenium.webdriver.support import expected_conditions as EC @@ -185,43 +183,4 @@ def on_click_update_graph(n_clicks): time.sleep(1) dash_dcc.percy_snapshot(f"Tabs-2 rendered ({is_eager})") - # do some extra tests while we're here - # and have access to Graph and plotly.js - check_graph_config_shape(dash_dcc) - - assert dash_dcc.get_logs() == [] - - -def check_graph_config_shape(dash_dcc): - config_schema = dash_dcc.driver.execute_script( - "return Plotly.PlotSchema.get().config;" - ) - with open(os.path.join(dcc.__path__[0], "metadata.json")) as meta: - graph_meta = json.load(meta)["src/components/Graph.react.js"] - config_prop_shape = graph_meta["props"]["config"]["type"]["value"] - - ignored_config = [ - "setBackground", - "showSources", - "logging", - "globalTransforms", - "notifyOnLogging", - "role", - "typesetMath", - ] - - def crawl(schema, props): - for prop_name in props: - assert prop_name in schema - - for item_name, item in schema.items(): - if item_name in ignored_config: - continue - - assert item_name in props - if "valType" not in item: - crawl(item, props[item_name]["value"]) - - crawl(config_schema, config_prop_shape) - assert dash_dcc.get_logs() == []