Fix unexpected ArrayIndexOutOfBoundsException when writing java.time.ZonedDateTime values to java.nio.DirectByteBuffer or java.io.OutputStream using an internal buffer of small size

Author: plokhotnyuk

jsoniter-scala-core/js/src/main/scala/com/github/plokhotnyuk/jsoniter_scala/core/JsonReader.scala

@@ -555,7 +555,7 @@ final class JsonReader private[jsoniter_scala](
     * Reads a JSON number value into a `Byte` value.
     *
     * @return a `Byte` value of the parsed JSON value
-    * @throws JsonReaderException in cases of reaching the end of input or dection of leading zero or
+    * @throws JsonReaderException in cases of reaching the end of input or detection of leading zero or
     *                             illegal format of JSON value or exceeding capacity of `Byte`
     */
   @inline

jsoniter-scala-core/js/src/main/scala/com/github/plokhotnyuk/jsoniter_scala/core/JsonWriter.scala

@@ -2191,15 +2191,15 @@ final class JsonWriter private[jsoniter_scala](
     pos = writeOffset(x.getOffset, writeLocalTime(x.toLocalTime, pos + 1, buf, ds), buf, ds)
     val zone = x.getZone
     if (!zone.isInstanceOf[ZoneOffset]) {
+      buf(pos) = '['
+      pos += 1
       val zoneId = zone.getId
       val len = zoneId.length
       val required = len + 3
       if (pos + required > limit) {
         pos = flushAndGrowBuf(required, pos)
         buf = this.buf
       }
-      buf(pos) = '['
-      pos += 1
       var i = 0
       while (i < len) {
         buf(pos) = zoneId.charAt(i).toByte

jsoniter-scala-core/jvm-native/src/main/scala/com/github/plokhotnyuk/jsoniter_scala/core/JsonReader.scala

@@ -555,7 +555,7 @@ final class JsonReader private[jsoniter_scala](
     * Reads a JSON number value into a `Byte` value.
     *
     * @return a `Byte` value of the parsed JSON value
-    * @throws JsonReaderException in cases of reaching the end of input or dection of leading zero or
+    * @throws JsonReaderException in cases of reaching the end of input or detection of leading zero or
     *                             illegal format of JSON value or exceeding capacity of `Byte`
     */
   def readByte(): Byte = readByte(isToken = true)

jsoniter-scala-core/jvm-native/src/main/scala/com/github/plokhotnyuk/jsoniter_scala/core/JsonWriter.scala

@@ -1961,14 +1961,14 @@ final class JsonWriter private[jsoniter_scala](
       writeLocalTime(x.toLocalTime, writeLocalDateWithT(x.toLocalDate, pos + 1, buf, ds), buf, ds), buf, ds)
     val zone = x.getZone
     if (!zone.isInstanceOf[ZoneOffset]) {
+      buf(pos - 1) = '['
       val zoneId = zone.getId
       val len = zoneId.length
       val required = len + 3
       if (pos + required > limit) {
         pos = flushAndGrowBuf(required, pos)
         buf = this.buf
       }
-      buf(pos - 1) = '['
       zoneId.getBytes(0, len, buf, pos)
       pos += len
       ByteArrayAccess.setShort(buf, pos, 0x225D)

jsoniter-scala-core/shared/src/test/scala/com/github/plokhotnyuk/jsoniter_scala/core/JsonReaderSpec.scala

@@ -2058,7 +2058,6 @@ class JsonReaderSpec extends AnyWordSpec with Matchers with ScalaCheckPropertyCh
         checkError(s""""+10:10:1${nonDigit}"""", "expected digit, offset: 0x00000009")
         checkError(s""""+10:10:10${nonDoubleQuotes}"""", """expected '"', offset: 0x0000000a""")
       }
-
     }
   }
   "JsonReader.isCharBufEqualsTo" should {