chore: mark commitish imports as unsupported

Author: dominykas

lib/travis/imports.js

@@ -15,6 +15,8 @@ const internals = {
 
 internals.normalizeImports = (travisYaml, { relativeTo }) => {
 
+    const context = relativeTo ? relativeTo.source : '.travis.yml';
+
     return Utils.toArray(travisYaml.import)
         .map((entry) => {
 
@@ -40,7 +42,11 @@ internals.normalizeImports = (travisYaml, { relativeTo }) => {
             }
 
             if (!internals.validMergeModes.has(entry.mode)) {
-                throw new Error(`Invalid merge mode for ${original} in ${relativeTo ? relativeTo.source : '.travis.yml'}: ${entry.mode}`);
+                throw new Error(`Invalid merge mode for ${original} in ${context}: ${entry.mode}`);
+            }
+
+            if (original.includes('@')) {
+                throw new Error(`Importing at commitish unsupported in ${context}: ${original}`);
             }
 
             return entry;

test/fixtures/index.js

@@ -93,6 +93,7 @@ module.exports = class TestContext {
         if (partials) {
             Fs.mkdirSync(Path.join(this.path, 'partials'));
             const partialYmls = [
+                'commitish.yml',
                 'indirect-node-14.yml',
                 'merge-invalid.yml',
                 'node-10.yml',

test/fixtures/travis-ymls/testing-imports/commitish.yml

@@ -0,0 +1,3 @@
+language: node_js
+import:
+  - source: partials/commitish.yml

test/fixtures/travis-ymls/testing-imports/partials/commitish.yml

@@ -0,0 +1,3 @@
+language: node_js
+import:
+  - source: partials/node-14.yml@main

test/travis.js

@@ -253,6 +253,26 @@ describe('.travis.yml parsing', () => {
 
         await expect(NodeSupport.detect({ path: fixture.path })).to.reject('Invalid merge mode for partials/node-12.yml in partials/merge-invalid.yml: no_such_merge_mode');
     });
+
+    it('throws when importing at commitish', async () => {
+
+        await fixture.setupRepoFolder({
+            partials: true,
+            travisYml: `testing-imports/partials/commitish.yml`
+        });
+
+        await expect(NodeSupport.detect({ path: fixture.path })).to.reject('Importing at commitish unsupported in .travis.yml: partials/node-14.yml@main');
+    });
+
+    it('throws when importing at commitish (indirect)', async () => {
+
+        await fixture.setupRepoFolder({
+            partials: true,
+            travisYml: `testing-imports/commitish.yml`
+        });
+
+        await expect(NodeSupport.detect({ path: fixture.path })).to.reject('Importing at commitish unsupported in partials/commitish.yml: partials/node-14.yml@main');
+    });
 });
 
 describe('Travis merging algorithms', () => {