Merge pull request #18 from pkgjs/fix-16

Return results when no .travis.yml in the repo

Author: dominykas

lib/loader.js

@@ -94,7 +94,9 @@ internals.createRepositoryLoader = (repository) => {
             catch (err) {
 
                 if (err.output && err.output.statusCode === 404) {
-                    throw new Error(`${repository} does not contain a ${filename}`);
+                    const error = new Error(`${repository} does not contain a ${filename}`);
+                    error.code = 'ENOENT';
+                    throw error;
                 }
 
                 throw err;
@@ -126,10 +128,6 @@ internals.createPathLoader = async (path) => {
 
             const fullPath = Path.join(path, filename);
 
-            if (!Fs.existsSync(fullPath)) {
-                return;
-            }
-
             const buffer = Fs.readFileSync(fullPath);
 
             if (options.json) {

lib/travis.js

@@ -78,10 +78,16 @@ internals.scan = async (travisYaml) => {
 
 exports.detect = async ({ loadFile }) => {
 
-    const buffer = await loadFile('.travis.yml');
+    try {
+        var buffer = await loadFile('.travis.yml');
+    }
+    catch (err) {
+
+        if (err.code === 'ENOENT') {
+            return;
+        }
 
-    if (buffer === undefined) {
-        return;
+        throw err;
     }
 
     const travisYaml = Yaml.safeLoad(buffer, { schema: Yaml.FAILSAFE_SCHEMA });

test/index.js

@@ -500,6 +500,46 @@ describe('detect-node-support', () => {
                 });
             });
 
+            it('leaves out `travis` when no `.travis.yml` present', async () => {
+
+                listRemoteStub
+                    .returns('9cef39d21ad229dea4b10295f55b0d9a83800b23\tHEAD\n');
+
+                Nock('https://raw.githubusercontent.com')
+                    .get('/pkgjs/detect-node-support/HEAD/package.json')
+                    .reply(200, Fs.readFileSync(Path.join(__dirname, '..', 'package.json')))
+                    .get('/pkgjs/detect-node-support/HEAD/.travis.yml')
+                    .reply(404);
+
+                const result = await NodeSupport.detect({ repository: 'git+https://github.com/pkgjs/detect-node-support.git' });
+
+                expect(listRemoteStub.callCount).to.equal(1);
+                expect(listRemoteStub.args[0]).to.equal([['http://github.com/pkgjs/detect-node-support.git', 'HEAD']]);
+
+                expect(result).to.equal({
+                    name: 'detect-node-support',
+                    version: '0.0.0-development',
+                    commit: '9cef39d21ad229dea4b10295f55b0d9a83800b23',
+                    timestamp: 1580673602000,
+                    engines: '>=10'
+                });
+            });
+
+            it('throws when loading `.travis.yml` fails', async () => {
+
+                listRemoteStub
+                    .returns('9cef39d21ad229dea4b10295f55b0d9a83800b23\tHEAD\n');
+
+                Nock('https://raw.githubusercontent.com')
+                    .get('/pkgjs/detect-node-support/HEAD/package.json')
+                    .reply(200, Fs.readFileSync(Path.join(__dirname, '..', 'package.json')))
+                    .get('/pkgjs/detect-node-support/HEAD/.travis.yml')
+                    .reply(500);
+
+                await expect(NodeSupport.detect({ repository: 'git+https://github.com/pkgjs/detect-node-support.git' }))
+                    .to.reject('Response Error: 500 null'); // the null is a Nock/Wreck implementation detail
+            });
+
             it('throws when repository does not have a package.json', async () => {
 
                 listRemoteStub
@@ -583,6 +623,35 @@ describe('detect-node-support', () => {
                 });
             });
 
+            it('leaves out `travis` when no `.travis.yml` present', async () => {
+
+                listRemoteStub
+                    .returns('9cef39d21ad229dea4b10295f55b0d9a83800b23\tHEAD\n');
+
+                Nock('https://raw.githubusercontent.com')
+                    .get('/pkgjs/detect-node-support/HEAD/package.json')
+                    .reply(200, Fs.readFileSync(Path.join(__dirname, '..', 'package.json')))
+                    .get('/pkgjs/detect-node-support/HEAD/.travis.yml')
+                    .reply(404);
+
+                Nock('https://registry.npmjs.org')
+                    .get('/detect-node-support')
+                    .reply(200, Fs.readFileSync(Path.join(__dirname, '..', 'package.json')));
+
+                const result = await NodeSupport.detect({ packageName: 'detect-node-support' });
+
+                expect(listRemoteStub.callCount).to.equal(1);
+                expect(listRemoteStub.args[0]).to.equal([['http://github.com/pkgjs/detect-node-support.git', 'HEAD']]);
+
+                expect(result).to.equal({
+                    name: 'detect-node-support',
+                    version: '0.0.0-development',
+                    commit: '9cef39d21ad229dea4b10295f55b0d9a83800b23',
+                    timestamp: 1580673602000,
+                    engines: '>=10'
+                });
+            });
+
             it('throws when package does not exist in the registry', async () => {
 
                 Nock('https://registry.npmjs.org')