Skip to content

Commit 29846a6

Browse files
committed
QA: Move library import to a fixture.
1 parent 525805b commit 29846a6

File tree

2 files changed

+19
-20
lines changed

2 files changed

+19
-20
lines changed

tests/conftest.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,16 @@
1+
import sys
2+
13
import pytest
24
from i2cdevice import MockSMBus
35

46

57
@pytest.fixture(scope='function', autouse=False)
68
def i2c_dev():
79
yield MockSMBus(1)
10+
11+
12+
@pytest.fixture(scope='function', autouse=False)
13+
def DRV8830():
14+
from drv8830 import DRV8830
15+
yield DRV8830
16+
del sys.modules["drv8830"]

tests/test_features.py

Lines changed: 10 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -1,62 +1,52 @@
1-
def test_forward(i2c_dev):
2-
from drv8830 import DRV8830
1+
def test_forward(DRV8830, i2c_dev):
32
drv8830 = DRV8830(i2c_dev=i2c_dev)
43
drv8830.forward()
54

65

7-
def test_reverse(i2c_dev):
8-
from drv8830 import DRV8830
6+
def test_reverse(DRV8830, i2c_dev):
97
drv8830 = DRV8830(i2c_dev=i2c_dev)
108
drv8830.reverse()
119

1210

13-
def test_brake(i2c_dev):
14-
from drv8830 import DRV8830
11+
def test_brake(DRV8830, i2c_dev):
1512
drv8830 = DRV8830(i2c_dev=i2c_dev)
1613
drv8830.brake()
1714

1815

19-
def test_coast(i2c_dev):
20-
from drv8830 import DRV8830
16+
def test_coast(DRV8830, i2c_dev):
2117
drv8830 = DRV8830(i2c_dev=i2c_dev)
2218
drv8830.coast()
2319

2420

25-
def test_set_outputs(i2c_dev):
26-
from drv8830 import DRV8830
21+
def test_set_outputs(DRV8830, i2c_dev):
2722
drv8830 = DRV8830(i2c_dev=i2c_dev)
2823
drv8830.set_outputs(out1=0, out2=0)
2924

3025

31-
def test_set_voltage(i2c_dev):
32-
from drv8830 import DRV8830
26+
def test_set_voltage(DRV8830, i2c_dev):
3327
drv8830 = DRV8830(i2c_dev=i2c_dev)
3428
drv8830.set_voltage(5.06)
3529
assert drv8830.get_voltage() == 5.06
3630

3731

38-
def test_set_voltage_snap(i2c_dev):
32+
def test_set_voltage_snap(DRV8830, i2c_dev):
3933
# Should snap to the nearest available voltage and read back correctly
40-
from drv8830 import DRV8830
4134
drv8830 = DRV8830(i2c_dev=i2c_dev)
4235
drv8830.set_voltage(0.82)
4336
assert drv8830.get_voltage() == 0.80
4437

4538

46-
def test_voltage_out_of_range(i2c_dev):
47-
from drv8830 import DRV8830
39+
def test_voltage_out_of_range(DRV8830, i2c_dev):
4840
drv8830 = DRV8830(i2c_dev=i2c_dev)
4941
drv8830.set_voltage(0)
5042
assert drv8830.get_voltage() == 0
5143

5244

53-
def test_get_fault(i2c_dev):
54-
from drv8830 import DRV8830
45+
def test_get_fault(DRV8830, i2c_dev):
5546
drv8830 = DRV8830(i2c_dev=i2c_dev)
5647
assert drv8830.get_fault().current_limit == 0
5748

5849

59-
def test_clear_fault(i2c_dev):
60-
from drv8830 import DRV8830
50+
def test_clear_fault(DRV8830, i2c_dev):
6151
drv8830 = DRV8830(i2c_dev=i2c_dev)
6252
drv8830.clear_fault()

0 commit comments

Comments
 (0)