Skip to content

Conversation

@dimitricole
Copy link

This change adds support for validators that require real signatures during gas estimation, such as Kernel v3 custom validators.

Changes:

  • Add strictValidation parameter to ToKernelSmartAccountParameters
  • Update sendTransaction to sign UserOperations before gas estimation when strictValidation is enabled
  • Add tests verifying strictValidation behavior

The feature is backward compatible, defaulting to false to maintain existing behavior.

This change adds support for validators that require real signatures during gas estimation, such as Kernel v3 custom validators.

Changes:
- Add strictValidation parameter to ToKernelSmartAccountParameters
- Update sendTransaction to sign UserOperations before gas estimation when strictValidation is enabled
- Add tests verifying strictValidation behavior

The feature is backward compatible, defaulting to false to maintain existing behavior.
@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2025

⚠️ No Changeset found

Latest commit: 826a55b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@plusminushalf
Copy link
Member

Can you share the specific use case where the estimations were wrong and you had to resolve to a strict use case of using the actual signature?

If someone does want to estimate with real signature they should themselves use the low level functions as this is not the expected behaviour. The expected behaviour for calls is:

Also signing a user operation which is not fully prepared can also lead to security issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants